Review Request 165: Preparation for 0.5.1: [2/14] Fixed traceback in EnumerateInstances on LMI_LocalFileSystem.

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/165/
-----------------------------------------------------------

Review request for OpenLMI Developers.


Repository: openlmi-storage


Description
-------

Fixed traceback in EnumerateInstances on LMI_LocalFileSystem.

CIM_ERR_FAILED: Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/cmpi_pywbem_bindings.py", line 82, in
__call__
    return self.meth(*args, **kwds)
  File "/usr/lib/python2.7/site-packages/cmpi_pywbem_bindings.py", line 487, in
enum_instances
    for i in self.proxy.MI_enumInstances(env, op, plist):
  File "/usr/lib/python2.7/site-packages/openlmi/storage/FormatProvider.py",
line 144, in enum_instances
    yield self.get_instance(env, model, fmt)
  File "/usr/lib/python2.7/site-packages/openlmi/common/cmpi_logging.py", line
81, in helper_func
    ret = func(*args, **kwargs)
  File
"/usr/lib/python2.7/site-packages/openlmi/storage/LocalFileSystemProvider.py",
line 321, in get_instance
    uuid = self.get_uuid(device, fmt)
UnboundLocalError: local variable 'device' referenced before assignment


Diffs
-----

  src/openlmi/storage/LocalFileSystemProvider.py ca8478dbe833e2df34c16ecc5e6df74aa01b3774


Diff: http://reviewboard-openlmi.rhcloud.com/r/165/diff/


Testing
-------


Thanks,

Jan Safranek

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/165/#review168
-----------------------------------------------------------

Ship it!


Ship It!

- Radek Novacek


On April 10, 2013, 3:47 p.m., Jan Safranek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/165/
>  -----------------------------------------------------------
>  
>  (Updated April 10, 2013, 3:47 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-storage
>  
>  
>  Description
>  -------
>  
>  Fixed traceback in EnumerateInstances on LMI_LocalFileSystem.
>  
>  CIM_ERR_FAILED: Traceback (most recent call last):
>    File "/usr/lib/python2.7/site-packages/cmpi_pywbem_bindings.py", line 82, in
> __call__
>      return self.meth(*args, **kwds)
>    File "/usr/lib/python2.7/site-packages/cmpi_pywbem_bindings.py", line 487, in
> enum_instances
>      for i in self.proxy.MI_enumInstances(env, op, plist):
>    File "/usr/lib/python2.7/site-packages/openlmi/storage/FormatProvider.py",
> line 144, in enum_instances
>      yield self.get_instance(env, model, fmt)
>    File "/usr/lib/python2.7/site-packages/openlmi/common/cmpi_logging.py", line
> 81, in helper_func
>      ret = func(*args, **kwargs)
>    File
> "/usr/lib/python2.7/site-packages/openlmi/storage/LocalFileSystemProvider.py",
> line 321, in get_instance
>      uuid = self.get_uuid(device, fmt)
>  UnboundLocalError: local variable 'device' referenced before assignment
>  
>  
>  Diffs
>  -----
>  
>    src/openlmi/storage/LocalFileSystemProvider.py ca8478dbe833e2df34c16ecc5e6df74aa01b3774
>
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/165/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Jan Safranek
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/165/
-----------------------------------------------------------

(Updated April 10, 2013, 4:25 p.m.)


Status
------

This change has been marked as submitted.


Review request for OpenLMI Developers.


Repository: openlmi-storage


Description
-------

Fixed traceback in EnumerateInstances on LMI_LocalFileSystem.

CIM_ERR_FAILED: Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/cmpi_pywbem_bindings.py", line 82, in
__call__
    return self.meth(*args, **kwds)
  File "/usr/lib/python2.7/site-packages/cmpi_pywbem_bindings.py", line 487, in
enum_instances
    for i in self.proxy.MI_enumInstances(env, op, plist):
  File "/usr/lib/python2.7/site-packages/openlmi/storage/FormatProvider.py",
line 144, in enum_instances
    yield self.get_instance(env, model, fmt)
  File "/usr/lib/python2.7/site-packages/openlmi/common/cmpi_logging.py", line
81, in helper_func
    ret = func(*args, **kwargs)
  File
"/usr/lib/python2.7/site-packages/openlmi/storage/LocalFileSystemProvider.py",
line 321, in get_instance
    uuid = self.get_uuid(device, fmt)
UnboundLocalError: local variable 'device' referenced before assignment


Diffs
-----

  src/openlmi/storage/LocalFileSystemProvider.py ca8478dbe833e2df34c16ecc5e6df74aa01b3774


Diff: http://reviewboard-openlmi.rhcloud.com/r/165/diff/


Testing
-------


Thanks,

Jan Safranek