Review Request 126: openlmi-networking [1/3] Rework setting creation methods

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/126/
-----------------------------------------------------------

Review request for OpenLMI Developers.


Repository: openlmi-networking


Description
-------

Rework setting creation methods

Methods CreateStaticSetting and CreateDHCPSetting was renamed to
CreateOrModifyStaticSetting and CreateOrModifyDynamicSetting.

Both of them now can be used to modify existing setting when SettingData
input argument is supplied.

CreateOrModifyStaticSetting now supports multiple IP addresses,
netmasks/prefixes and gateways -- it's more aligned with
ExtendedStaticIPAssignmentSettingData class.


Diffs
-----

  mof/LMI_Networking.mof fb9580105931ba03d1895279d9af561a0e5c5b46 
  src/LMI_IPAssignmentSettingDataProvider.c c3b632c49378233432945cbb8bd3f215425b96ae 
  src/LMI_IPConfigurationServiceProvider.c 14af9e65aa0948955a551ac1edce1f5262a28588 
  src/connection.h 668460a76d97e0195e53804c29f631b095df2782 
  src/connection.c 7678cab5785e6b95edef103dbf3a3fa5f0612efd 
  src/connection_nm.c a0b92223c0bc1a18a29d7bf3342cf5423c835c7f 
  src/setting.h 514e7f0469085e73d3293a060752a0193816d9fd 
  src/setting.c 25fa7cbad6e8d52359d0142c7210fa8e6a9d5d71 
  test/test_apply_connection.py 887cf7825a316ffc437eae650cb55afff02c7b0d 
  test/test_create_destroy_connection.py b278d6acfbb509a8398926f3d6106a92adbe1dcc 
  test/test_enable_disable_iface.py 792d3ade8a854ecea38b70ac7d73e157f59f0e53 
  test/test_modify_connection.py PRE-CREATION 

Diff: http://reviewboard-openlmi.rhcloud.com/r/126/diff/


Testing
-------


Thanks,

Radek Novacek

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/126/
-----------------------------------------------------------

(Updated April 8, 2013, 3:26 p.m.)


Status
------

This change has been discarded.


Review request for OpenLMI Developers.


Repository: openlmi-networking


Description
-------

Rework setting creation methods

Methods CreateStaticSetting and CreateDHCPSetting was renamed to
CreateOrModifyStaticSetting and CreateOrModifyDynamicSetting.

Both of them now can be used to modify existing setting when SettingData
input argument is supplied.

CreateOrModifyStaticSetting now supports multiple IP addresses,
netmasks/prefixes and gateways -- it's more aligned with
ExtendedStaticIPAssignmentSettingData class.


Diffs
-----

  mof/LMI_Networking.mof fb9580105931ba03d1895279d9af561a0e5c5b46 
  src/LMI_IPAssignmentSettingDataProvider.c c3b632c49378233432945cbb8bd3f215425b96ae 
  src/LMI_IPConfigurationServiceProvider.c 14af9e65aa0948955a551ac1edce1f5262a28588 
  src/connection.h 668460a76d97e0195e53804c29f631b095df2782 
  src/connection.c 7678cab5785e6b95edef103dbf3a3fa5f0612efd 
  src/connection_nm.c a0b92223c0bc1a18a29d7bf3342cf5423c835c7f 
  src/setting.h 514e7f0469085e73d3293a060752a0193816d9fd 
  src/setting.c 25fa7cbad6e8d52359d0142c7210fa8e6a9d5d71 
  test/test_apply_connection.py 887cf7825a316ffc437eae650cb55afff02c7b0d 
  test/test_create_destroy_connection.py b278d6acfbb509a8398926f3d6106a92adbe1dcc 
  test/test_enable_disable_iface.py 792d3ade8a854ecea38b70ac7d73e157f59f0e53 
  test/test_modify_connection.py PRE-CREATION 

Diff: http://reviewboard-openlmi.rhcloud.com/r/126/diff/


Testing
-------


Thanks,

Radek Novacek