Review Request 876: [1/1] Providers: Added -fstack-protector gcc flag.

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/876/
-----------------------------------------------------------

Review request for OpenLMI Developers.


Repository: openlmi-providers


Description
-------

Providers: Added -fstack-protector gcc flag.


Diffs
-----

  CMakeLists.txt d3184e9c70707e9c708082ec09dd3be18b4dbe38 

Diff: http://reviewboard-openlmi.rhcloud.com/r/876/diff/


Testing
-------


Thanks,

Robin Hack


_______________________________________________
openlmi-reviews mailing list
openlmi-reviews(a)lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/openlmi-reviews

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/876/#review1213
-----------------------------------------------------------


I would rather turn on "-fstack-protector-strong", Fedora already switched to it
in rawhide, see https://fedorahosted.org/fesco/ticket/1128

- Radek Novacek


On Sept. 19, 2013, 7:53 a.m., Robin Hack wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/876/
>  -----------------------------------------------------------
>  
>  (Updated Sept. 19, 2013, 7:53 a.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  Providers: Added -fstack-protector gcc flag.
>  
>  
>  Diffs
>  -----
>  
>    CMakeLists.txt d3184e9c70707e9c708082ec09dd3be18b4dbe38 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/876/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Robin Hack
>  
>  

_______________________________________________
openlmi-reviews mailing list
openlmi-reviews(a)lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/openlmi-reviews

Review Request 876: [1/1] Providers: Added -fstack-protector-strong gcc flag.

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/876/
-----------------------------------------------------------

(Updated Sept. 19, 2013, 6:14 a.m.)


Review request for OpenLMI Developers.


Summary (updated)
-----------------

[1/1] Providers: Added -fstack-protector-strong gcc flag.


Repository: openlmi-providers


Description
-------

Providers: Added -fstack-protector gcc flag.


Diffs (updated)
-----

  CMakeLists.txt d3184e9c70707e9c708082ec09dd3be18b4dbe38 

Diff: http://reviewboard-openlmi.rhcloud.com/r/876/diff/


Testing
-------


Thanks,

Robin Hack


_______________________________________________
openlmi-reviews mailing list
openlmi-reviews(a)lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/openlmi-reviews

Review Request 876: [1/1] Providers: Added -fstack-protector-strong gcc flag.

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/876/#review1214
-----------------------------------------------------------

Ship it!


Ship It!

- Radek Novacek


On Sept. 19, 2013, 8:14 a.m., Robin Hack wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/876/
>  -----------------------------------------------------------
>  
>  (Updated Sept. 19, 2013, 8:14 a.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  Providers: Added -fstack-protector gcc flag.
>  
>  
>  Diffs
>  -----
>  
>    CMakeLists.txt d3184e9c70707e9c708082ec09dd3be18b4dbe38 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/876/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Robin Hack
>  
>  

_______________________________________________
openlmi-reviews mailing list
openlmi-reviews(a)lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/openlmi-reviews

Review Request 876: [1/1] Providers: Added -fstack-protector-strong gcc flag.

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/876/
-----------------------------------------------------------

(Updated Sept. 19, 2013, 6:19 a.m.)


Status
------

This change has been marked as submitted.


Review request for OpenLMI Developers.


Repository: openlmi-providers


Description
-------

Providers: Added -fstack-protector gcc flag.


Diffs
-----

  CMakeLists.txt d3184e9c70707e9c708082ec09dd3be18b4dbe38 

Diff: http://reviewboard-openlmi.rhcloud.com/r/876/diff/


Testing
-------


Thanks,

Robin Hack


_______________________________________________
openlmi-reviews mailing list
openlmi-reviews(a)lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/openlmi-reviews