----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/139/ -----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-storage
Description -------
Add mounting.mof.
Diffs -----
mof/mounting.mof PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/139/diff/
Testing -------
Thanks,
Jan Synacek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/139/#review120 -----------------------------------------------------------
mof/mounting.mof http://reviewboard-openlmi.rhcloud.com/r/139/#comment66
Shouldn't this be "Corresponds to 'user' mount option" ?
mof/mounting.mof http://reviewboard-openlmi.rhcloud.com/r/139/#comment67
an -> a
mof/mounting.mof http://reviewboard-openlmi.rhcloud.com/r/139/#comment68
"If binding a local filesystem" - shouldn't it be "If mounting a local filesystem"?
- Radek Novacek
On April 8, 2013, 3:22 p.m., Jan Synacek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/139/
(Updated April 8, 2013, 3:22 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-storage
Description
Add mounting.mof.
Diffs
mof/mounting.mof PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/139/diff/
Testing
Thanks,
Jan Synacek
On April 9, 2013, 8:44 a.m., Radek Novacek wrote:
mof/mounting.mof, line 107 http://reviewboard-openlmi.rhcloud.com/r/139/diff/1/?file=746#file746line107
Shouldn't this be "Corresponds to 'user' mount option" ?
Yes, this is fixed in [3/10] part of the series.
On April 9, 2013, 8:44 a.m., Radek Novacek wrote:
mof/mounting.mof, line 152 http://reviewboard-openlmi.rhcloud.com/r/139/diff/1/?file=746#file746line152
an -> a
I'm pretty sure 'an' is correct here. Try pronouncing 'L' (pronounciation begins with a vowel).
On April 9, 2013, 8:44 a.m., Radek Novacek wrote:
mof/mounting.mof, line 212 http://reviewboard-openlmi.rhcloud.com/r/139/diff/1/?file=746#file746line212
"If binding a local filesystem" - shouldn't it be "If mounting a local filesystem"?
Yes, it should be 'mounting'. I'll fix it.
- Jan
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/139/#review120 -----------------------------------------------------------
On April 8, 2013, 3:22 p.m., Jan Synacek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/139/
(Updated April 8, 2013, 3:22 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-storage
Description
Add mounting.mof.
Diffs
mof/mounting.mof PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/139/diff/
Testing
Thanks,
Jan Synacek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/139/#review132 -----------------------------------------------------------
mof/mounting.mof http://reviewboard-openlmi.rhcloud.com/r/139/#comment75
Options 'auto' and 'user' are *not* omitted.
mof/mounting.mof http://reviewboard-openlmi.rhcloud.com/r/139/#comment76
I think 'Size Not Supported' could be removed from the value map, IMHO it makes no sense in this method or in ModifyMount and DeleteMount.
mof/mounting.mof http://reviewboard-openlmi.rhcloud.com/r/139/#comment77
I would add: 'For bind mounts, this is path to source directory of the bind mount.'
- Jan Safranek
On April 8, 2013, 3:22 p.m., Jan Synacek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/139/
(Updated April 8, 2013, 3:22 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-storage
Description
Add mounting.mof.
Diffs
mof/mounting.mof PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/139/diff/
Testing
Thanks,
Jan Synacek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/139/#review134 -----------------------------------------------------------
mof/mounting.mof http://reviewboard-openlmi.rhcloud.com/r/139/#comment79
why don't we have 'bind' filesystem type for bind mounts? I am sure we talked about it, i don't remember the reason... NULL looks weird here.
mof/mounting.mof http://reviewboard-openlmi.rhcloud.com/r/139/#comment80
1) I miss some note that IsNext and IsCurrent are properties of LMI_MountedFileSystemElementSettingData, which will be created.
2) I would also emphasize what these IsNext and IsCurrent properties actually mean, e.g.: Mode 1 - IsNext = 1, IsCurrent = 1: The filesystem will be mounted and also stored in /etc/fstab. (applies to ModifyMount/DeleteMount too)
mof/mounting.mof http://reviewboard-openlmi.rhcloud.com/r/139/#comment81
IMHO the list of modes can be shortened, e.g. Mode1 does not apply to DeleteMount.
mof/mounting.mof http://reviewboard-openlmi.rhcloud.com/r/139/#comment82
You can use - LMI_MountedFileSystem instead of CIM_ManagedElement - correct subclass instead of CIM_Capabilities and CIM_SettingData
- Jan Safranek
On April 8, 2013, 3:22 p.m., Jan Synacek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/139/
(Updated April 8, 2013, 3:22 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-storage
Description
Add mounting.mof.
Diffs
mof/mounting.mof PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/139/diff/
Testing
Thanks,
Jan Synacek
On April 9, 2013, 4:08 p.m., Jan Safranek wrote:
mof/mounting.mof, lines 211-215 http://reviewboard-openlmi.rhcloud.com/r/139/diff/1/?file=746#file746line211
why don't we have 'bind' filesystem type for bind mounts? I am sure we talked about it, i don't remember the reason... NULL looks weird here.
Because you don't specify a filesystem when performing a bind mount. See discussion in this thread: https://lists.fedorahosted.org/pipermail/openlmi-devel/2013-March/000090.htm...
- Jan
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/139/#review134 -----------------------------------------------------------
On April 8, 2013, 3:22 p.m., Jan Synacek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/139/
(Updated April 8, 2013, 3:22 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-storage
Description
Add mounting.mof.
Diffs
mof/mounting.mof PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/139/diff/
Testing
Thanks,
Jan Synacek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/139/ -----------------------------------------------------------
(Updated April 17, 2013, 10:06 a.m.)
Status ------
This change has been discarded.
Review request for OpenLMI Developers.
Repository: openlmi-storage
Description -------
Add mounting.mof.
Diffs -----
mof/mounting.mof PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/139/diff/
Testing -------
Thanks,
Jan Synacek
openlmi-devel@lists.fedorahosted.org