Review Request 276: openlmi-networking [2/4] Simplify connection modifications

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/276/
-----------------------------------------------------------

Review request for OpenLMI Developers.


Repository: openlmi-networking


Description
-------

Simplify connection modifications

Connections are now cloned and then modified. It's easier to use it this
way if there is only some minor change (like changed dns server).


Diffs
-----

  src/LMI_ExtendedStaticIPAssignmentSettingDataProvider.c
e4d9a14e63343ada59ac3db82c36f31cf03f3b3a 
  src/LMI_IPAssignmentSettingDataProvider.c 8585488715694b9db420eace5a022b578f3208a4 
  src/connection.h 7e6d6206bae139a0d4d066f400ae78b0c70ab12d 
  src/connection.c 969232810f0342d15f8e75c64bf841b6a42b065f 
  src/connection_nm.c a5fba58e1eab8f5dc5ba3793ad247da8dbf404e0 
  src/setting.h 80e8591f98c8378aff2ea4389f69a8f67df2578b 
  src/setting.c 91e311779829b23c927660add0bc68e479e655a4 

Diff: http://reviewboard-openlmi.rhcloud.com/r/276/diff/


Testing
-------


Thanks,

Radek Novacek

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/276/#review330
-----------------------------------------------------------

Ship it!


- Jan Synacek


On April 26, 2013, 3:39 p.m., Radek Novacek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/276/
>  -----------------------------------------------------------
>  
>  (Updated April 26, 2013, 3:39 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-networking
>  
>  
>  Description
>  -------
>  
>  Simplify connection modifications
>  
>  Connections are now cloned and then modified. It's easier to use it this
>  way if there is only some minor change (like changed dns server).
>  
>  
>  Diffs
>  -----
>  
>    src/LMI_ExtendedStaticIPAssignmentSettingDataProvider.c
> e4d9a14e63343ada59ac3db82c36f31cf03f3b3a 
>    src/LMI_IPAssignmentSettingDataProvider.c 8585488715694b9db420eace5a022b578f3208a4 
>    src/connection.h 7e6d6206bae139a0d4d066f400ae78b0c70ab12d 
>    src/connection.c 969232810f0342d15f8e75c64bf841b6a42b065f 
>    src/connection_nm.c a5fba58e1eab8f5dc5ba3793ad247da8dbf404e0 
>    src/setting.h 80e8591f98c8378aff2ea4389f69a8f67df2578b 
>    src/setting.c 91e311779829b23c927660add0bc68e479e655a4 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/276/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Radek Novacek
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/276/
-----------------------------------------------------------

(Updated April 29, 2013, 9:57 a.m.)


Status
------

This change has been marked as submitted.


Review request for OpenLMI Developers.


Repository: openlmi-networking


Description
-------

Simplify connection modifications

Connections are now cloned and then modified. It's easier to use it this
way if there is only some minor change (like changed dns server).


Diffs
-----

  src/LMI_ExtendedStaticIPAssignmentSettingDataProvider.c
e4d9a14e63343ada59ac3db82c36f31cf03f3b3a 
  src/LMI_IPAssignmentSettingDataProvider.c 8585488715694b9db420eace5a022b578f3208a4 
  src/connection.h 7e6d6206bae139a0d4d066f400ae78b0c70ab12d 
  src/connection.c 969232810f0342d15f8e75c64bf841b6a42b065f 
  src/connection_nm.c a5fba58e1eab8f5dc5ba3793ad247da8dbf404e0 
  src/setting.h 80e8591f98c8378aff2ea4389f69a8f67df2578b 
  src/setting.c 91e311779829b23c927660add0bc68e479e655a4 

Diff: http://reviewboard-openlmi.rhcloud.com/r/276/diff/


Testing
-------


Thanks,

Radek Novacek