Review Request 187: JobManager sync: [1/5] Synchronize JobManager with storage.

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/187/
-----------------------------------------------------------

Review request for OpenLMI Developers.


Repository: openlmi-providers


Description
-------

Synchronize JobManager with storage.

JobManager here is older version of the one in openlmi-storage.
Let's sync it with the storage so I can use it from there.

The patch includes:

Fixed job expiration under SFCB.
Added LMI_StorageJob.JobInParameters and .JobOutParameters properties.
Allow python to exit the provider even if there are threads running.
Fixed job returning an error
Added possibility to set AffectedElements when a job finishes.
Added workaround for rhbz#920763


Diffs
-----

  src/python/openlmi/common/JobManager.py a923f296d3eba40f1997a267b68525a44f50ffc7 

Diff: http://reviewboard-openlmi.rhcloud.com/r/187/diff/


Testing
-------


Thanks,

Jan Safranek

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/187/#review219
-----------------------------------------------------------



src/python/openlmi/common/JobManager.py
<http://reviewboard-openlmi.rhcloud.com/r/187/#comment129>

    Try to avoid using % to format string for log messages. It enforces formatting before
the log function is called and thus slows down the execution, when logging is suppressed.



src/python/openlmi/common/JobManager.py
<http://reviewboard-openlmi.rhcloud.com/r/187/#comment131>

    I would avoid this assignment. The default for path.keybindings is pywbem.NocaseDict,
which does lowercase key comparisons. With this plain dictionary the whole path behaves
differently and you have to bare it in mind, when using it afterwards.



src/python/openlmi/common/JobManager.py
<http://reviewboard-openlmi.rhcloud.com/r/187/#comment130>

    Maybe it's better to prevent logging by using different logger like:
      logging.getLogger('openlmi.separate_thread')
    
    which could have logging suppressed (runtime) or redirected to file (when debugging).


- Michal Minar


On April 12, 2013, 2:13 p.m., Jan Safranek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/187/
>  -----------------------------------------------------------
>  
>  (Updated April 12, 2013, 2:13 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  Synchronize JobManager with storage.
>  
>  JobManager here is older version of the one in openlmi-storage.
>  Let's sync it with the storage so I can use it from there.
>  
>  The patch includes:
>  
>  Fixed job expiration under SFCB.
>  Added LMI_StorageJob.JobInParameters and .JobOutParameters properties.
>  Allow python to exit the provider even if there are threads running.
>  Fixed job returning an error
>  Added possibility to set AffectedElements when a job finishes.
>  Added workaround for rhbz#920763
>  
>  
>  Diffs
>  -----
>  
>    src/python/openlmi/common/JobManager.py a923f296d3eba40f1997a267b68525a44f50ffc7 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/187/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Jan Safranek
>  
>

[Stephen Gallagher]

>  On April 16, 2013, 9:33 a.m., Michal Minar wrote:
>  > src/python/openlmi/common/JobManager.py, line 825
>  >
> <http://reviewboard-openlmi.rhcloud.com/r/187/diff/1/?file=1128#file1128li...
>  >
>  >     Maybe it's better to prevent logging by using different logger like:
>  >       logging.getLogger('openlmi.separate_thread')
>  >     
>  >     which could have logging suppressed (runtime) or redirected to file (when
> debugging). 
This will be fixed by TimerManager, patches will be available soon.


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/187/#review219
-----------------------------------------------------------


On April 12, 2013, 4:13 p.m., Jan Safranek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/187/
>  -----------------------------------------------------------
>  
>  (Updated April 12, 2013, 4:13 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  Synchronize JobManager with storage.
>  
>  JobManager here is older version of the one in openlmi-storage.
>  Let's sync it with the storage so I can use it from there.
>  
>  The patch includes:
>  
>  Fixed job expiration under SFCB.
>  Added LMI_StorageJob.JobInParameters and .JobOutParameters properties.
>  Allow python to exit the provider even if there are threads running.
>  Fixed job returning an error
>  Added possibility to set AffectedElements when a job finishes.
>  Added workaround for rhbz#920763
>  
>  
>  Diffs
>  -----
>  
>    src/python/openlmi/common/JobManager.py a923f296d3eba40f1997a267b68525a44f50ffc7 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/187/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Jan Safranek
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/187/#review220
-----------------------------------------------------------

Ship it!


Those were just nitpicks. Otherwise it's OK.

- Michal Minar


On April 12, 2013, 2:13 p.m., Jan Safranek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/187/
>  -----------------------------------------------------------
>  
>  (Updated April 12, 2013, 2:13 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  Synchronize JobManager with storage.
>  
>  JobManager here is older version of the one in openlmi-storage.
>  Let's sync it with the storage so I can use it from there.
>  
>  The patch includes:
>  
>  Fixed job expiration under SFCB.
>  Added LMI_StorageJob.JobInParameters and .JobOutParameters properties.
>  Allow python to exit the provider even if there are threads running.
>  Fixed job returning an error
>  Added possibility to set AffectedElements when a job finishes.
>  Added workaround for rhbz#920763
>  
>  
>  Diffs
>  -----
>  
>    src/python/openlmi/common/JobManager.py a923f296d3eba40f1997a267b68525a44f50ffc7 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/187/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Jan Safranek
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/187/
-----------------------------------------------------------

(Updated April 16, 2013, 9:43 a.m.)


Status
------

This change has been marked as submitted.


Review request for OpenLMI Developers.


Repository: openlmi-providers


Description
-------

Synchronize JobManager with storage.

JobManager here is older version of the one in openlmi-storage.
Let's sync it with the storage so I can use it from there.

The patch includes:

Fixed job expiration under SFCB.
Added LMI_StorageJob.JobInParameters and .JobOutParameters properties.
Allow python to exit the provider even if there are threads running.
Fixed job returning an error
Added possibility to set AffectedElements when a job finishes.
Added workaround for rhbz#920763


Diffs
-----

  src/python/openlmi/common/JobManager.py a923f296d3eba40f1997a267b68525a44f50ffc7 

Diff: http://reviewboard-openlmi.rhcloud.com/r/187/diff/


Testing
-------


Thanks,

Jan Safranek