Review Request 865: openlmi-providers [1/5] Introduce toplevel openlmi config file

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/865/
-----------------------------------------------------------

Review request for OpenLMI Developers.


Repository: openlmi-providers


Description
-------

Introduce toplevel openlmi config file

Toplevel openlmi configuration file (/etc/openlmi/openlmi.conf) now
contains common configuration options for all providers. Configuration
for each provider could be overriden in provider-specific config
(/etc/openlmi/$provider/$provider.conf).

This patch also modify config file handling in python providers to
include this config file.

There is also support for C providers (in libopenlmicommon) for reading
these config files and providing default configuration options.


Diffs
-----

  CMakeLists.txt 8bb4dd27f6104f5d792d7a25e53431cf4ab0cac8 
  openlmi-providers.spec f85faca43f569ecf5a9087103f3f7d95a48a1d96 
  src/CMakeLists.txt a9dc85d293b82805d4d956f1adbd212c873fd743 
  src/account/CMakeLists.txt a993094541546f46607d405f3be420a00885bd48 
  src/openlmi.c 3b46f8d4ec4393675e064fa9bedec875ac1f4032 
  src/openlmi.conf PRE-CREATION 
  src/openlmi.h 6ab4158fd08677729c91f50285f70abdd12c0dd1 
  src/python/lmi/base/BaseConfiguration.py 8790acfb7598a17b9a62da697f300e5765d437cb 

Diff: http://reviewboard-openlmi.rhcloud.com/r/865/diff/


Testing
-------


Thanks,

Radek Novacek


_______________________________________________
openlmi-reviews mailing list
openlmi-reviews(a)lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/openlmi-reviews

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/865/#review1183
-----------------------------------------------------------



src/openlmi.c
<http://reviewboard-openlmi.rhcloud.com/r/865/#comment737>

    s/Broken/Broker


- Jan Synacek


On Sept. 17, 2013, 3:51 p.m., Radek Novacek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/865/
>  -----------------------------------------------------------
>  
>  (Updated Sept. 17, 2013, 3:51 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  Introduce toplevel openlmi config file
>  
>  Toplevel openlmi configuration file (/etc/openlmi/openlmi.conf) now
>  contains common configuration options for all providers. Configuration
>  for each provider could be overriden in provider-specific config
>  (/etc/openlmi/$provider/$provider.conf).
>  
>  This patch also modify config file handling in python providers to
>  include this config file.
>  
>  There is also support for C providers (in libopenlmicommon) for reading
>  these config files and providing default configuration options.
>  
>  
>  Diffs
>  -----
>  
>    CMakeLists.txt 8bb4dd27f6104f5d792d7a25e53431cf4ab0cac8 
>    openlmi-providers.spec f85faca43f569ecf5a9087103f3f7d95a48a1d96 
>    src/CMakeLists.txt a9dc85d293b82805d4d956f1adbd212c873fd743 
>    src/account/CMakeLists.txt a993094541546f46607d405f3be420a00885bd48 
>    src/openlmi.c 3b46f8d4ec4393675e064fa9bedec875ac1f4032 
>    src/openlmi.conf PRE-CREATION 
>    src/openlmi.h 6ab4158fd08677729c91f50285f70abdd12c0dd1 
>    src/python/lmi/base/BaseConfiguration.py 8790acfb7598a17b9a62da697f300e5765d437cb 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/865/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Radek Novacek
>  
>  

_______________________________________________
openlmi-reviews mailing list
openlmi-reviews(a)lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/openlmi-reviews

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/865/#review1184
-----------------------------------------------------------

Ship it!


Ship It!

- Jan Synacek


On Sept. 17, 2013, 3:51 p.m., Radek Novacek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/865/
>  -----------------------------------------------------------
>  
>  (Updated Sept. 17, 2013, 3:51 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  Introduce toplevel openlmi config file
>  
>  Toplevel openlmi configuration file (/etc/openlmi/openlmi.conf) now
>  contains common configuration options for all providers. Configuration
>  for each provider could be overriden in provider-specific config
>  (/etc/openlmi/$provider/$provider.conf).
>  
>  This patch also modify config file handling in python providers to
>  include this config file.
>  
>  There is also support for C providers (in libopenlmicommon) for reading
>  these config files and providing default configuration options.
>  
>  
>  Diffs
>  -----
>  
>    CMakeLists.txt 8bb4dd27f6104f5d792d7a25e53431cf4ab0cac8 
>    openlmi-providers.spec f85faca43f569ecf5a9087103f3f7d95a48a1d96 
>    src/CMakeLists.txt a9dc85d293b82805d4d956f1adbd212c873fd743 
>    src/account/CMakeLists.txt a993094541546f46607d405f3be420a00885bd48 
>    src/openlmi.c 3b46f8d4ec4393675e064fa9bedec875ac1f4032 
>    src/openlmi.conf PRE-CREATION 
>    src/openlmi.h 6ab4158fd08677729c91f50285f70abdd12c0dd1 
>    src/python/lmi/base/BaseConfiguration.py 8790acfb7598a17b9a62da697f300e5765d437cb 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/865/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Radek Novacek
>  
>  

_______________________________________________
openlmi-reviews mailing list
openlmi-reviews(a)lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/openlmi-reviews

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/865/
-----------------------------------------------------------

(Updated Sept. 18, 2013, 8:12 a.m.)


Status
------

This change has been marked as submitted.


Review request for OpenLMI Developers.


Repository: openlmi-providers


Description
-------

Introduce toplevel openlmi config file

Toplevel openlmi configuration file (/etc/openlmi/openlmi.conf) now
contains common configuration options for all providers. Configuration
for each provider could be overriden in provider-specific config
(/etc/openlmi/$provider/$provider.conf).

This patch also modify config file handling in python providers to
include this config file.

There is also support for C providers (in libopenlmicommon) for reading
these config files and providing default configuration options.


Diffs
-----

  CMakeLists.txt 8bb4dd27f6104f5d792d7a25e53431cf4ab0cac8 
  openlmi-providers.spec f85faca43f569ecf5a9087103f3f7d95a48a1d96 
  src/CMakeLists.txt a9dc85d293b82805d4d956f1adbd212c873fd743 
  src/account/CMakeLists.txt a993094541546f46607d405f3be420a00885bd48 
  src/openlmi.c 3b46f8d4ec4393675e064fa9bedec875ac1f4032 
  src/openlmi.conf PRE-CREATION 
  src/openlmi.h 6ab4158fd08677729c91f50285f70abdd12c0dd1 
  src/python/lmi/base/BaseConfiguration.py 8790acfb7598a17b9a62da697f300e5765d437cb 

Diff: http://reviewboard-openlmi.rhcloud.com/r/865/diff/


Testing
-------


Thanks,

Radek Novacek


_______________________________________________
openlmi-reviews mailing list
openlmi-reviews(a)lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/openlmi-reviews