This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/897/ |
src/account/LMI_GroupProvider.c (Diff revision 1) | |||
---|---|---|---|
static CMPIStatus LMI_GroupDeleteInstance( |
|||
143 | const CMPIResult* cr, |
148 | static CMPIrc delete_group( |
Wouldn't it be better to return CMPIStatus - it contains both RC and error string?
src/account/LMI_GroupProvider.c (Diff revision 1) | |||
---|---|---|---|
static CMPIStatus LMI_GroupDeleteInstance( |
|||
180 | if (aux_lu_get_long(lueu, LU_GIDNUMBER) == aux_lu_get_long(lueg, LU_GIDNUMBER)) { |
I would cache aux_lu_get_long(lueg, LU_GIDNUMBER) before this cycle.
- Radek Novacek
On September 30th, 2013, 1:13 p.m. CEST, Roman Rakus wrote:
Review request for OpenLMI Developers.
By Roman Rakus.
Updated Sept. 30, 2013, 1:13 p.m.
Repository:
openlmi-providers
Description
Diffs
|