This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/840/

src/account/test/TestAccountQA.py (Diff revision 1)
		40	DEV_NULL = open("/dev/null", 'w')

Where is DEV_NULL used?

src/account/test/TestAccountQA.py (Diff revision 1)
		68	user = lams.CreateAccount(Name=myuser, System=cs)

Use hash instead of keys.

src/account/test/TestAccountQA.py (Diff revision 1)
		72	# modify user, thats bug with locks now

This should be standalone test case.

src/account/test/TestAccountQA.py (Diff revision 1)
		83	user = self.conn.root.cimv2.LMI_Account.first_instance(key="Name", value=myuser)

Use hash, not keys.

src/account/test/TestAccountQA.py (Diff revision 1)
		88	group = self.conn.root.cimv2.LMI_Group.first_instance(key="Name", value=myuser)

Use hash, not keys.

src/account/test/TestAccountQA.py (Diff revision 1)
		114	user = lams.CreateAccount(Name='root', System=cs)

Use hash, not keys.

src/account/test/TestAccountQA.py (Diff revision 1)
		130	group = lams.CreateGroup(Name=mygroup, System=cs)

Use hash, not keys.

src/account/test/TestAccountQA.py (Diff revision 1)
		135	user = lams.CreateAccount(Name=myuser, System=cs, GID=groupID)

Use hash, not keys.

src/account/test/TestAccountQA.py (Diff revision 1)
		139	user = self.conn.root.cimv2.LMI_Account.first_instance(key="Name", value=myuser)

Use hash, not keys.

src/account/test/TestAccountQA.py (Diff revision 1)
		144	group = self.conn.root.cimv2.LMI_Group.first_instance(key="Name", value=mygroup)

Use hash, not keys.

- Robin Hack

On September 10th, 2013, 7:10 a.m. UTC, Robin Hack wrote:

Review request for OpenLMI Developers.

By Robin Hack.

Updated Sept. 10, 2013, 7:10 a.m.

Repository: openlmi-providers

Description

Account: First upstream account test from qa.

Diffs