On September 2nd, 2013, 11:23 a.m. UTC, Jan Safranek wrote:

src/account/lock.h (Diff revision 1)
		19	lock_node_t tail;

why is 'tail' lock_node_t? tail.next & tail.lock are never used.

IMHO it should be lock_node_t *, pointing to the last item in the list or NULL when the list is empty.

It will make the code below more readable.

This solution has ideological reasons.
Removing of last node is easier than with dynamic tail.
With pointer to last element i must solve that this element is not last.
Same in case, when i add new element to empty list.

On September 2nd, 2013, 11:23 a.m. UTC, Jan Safranek wrote:

src/account/lock.c (Diff revision 1)
		98	lock_node_t *new_node = malloc (sizeof (lock_node_t));

use calloc or initialize new_node->lock->id to zeroes otherwise, you're expecting that on line 108.

Good point. Fixed.

- Robin

On September 2nd, 2013, 9:50 a.m. UTC, Robin Hack wrote:

Account: Added associative thread locking.

Missing files included.