This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1775/

src/software-dbus/sw-utils.c (Diff revision 1)
void enum_sw_identity_instances(PkBitfield filters, const CMPIBroker *cb,
		588	g_free(pkg_id);

nitpick: in situations like this I would prefer to set pkg_id to NULL after free, as later you are passing it again to the g_object_get() fn; but it should be harmless as it is now

src/software-dbus/sw-utils.c (Diff revision 1)
gint pk_pkg_cmp(gpointer a, gpointer b)
		842	return (gint) strcmp(pkg_id_a, pkg_id_b);

pkg_id_a and pkg_id_b need to be freed; see pk_repo_cmp() fn

- Peter Schiffer

On June 10th, 2014, 1:49 p.m. CEST, Michal Minar wrote:

Review request for OpenLMI Developers.

By Michal Minar.

Updated June 10, 2014, 1:49 p.m.

Repository: openlmi-providers

Description

support older versions of PackageKit api

Functions like:
    pk_details_get_package_id
    pk_details_get_description
are available since version 0.8.12. In RHEL7 we have 0.8.9. Let's avoid
using them.

Diffs

src/software-dbus/sw-utils.c (6b1424d66e8a83f74db83157771b6f30d651e184)

View Diff