This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/430/ |
On June 6th, 2013, 9:02 a.m. CEST, Radek Novacek wrote:
mof/60_LMI_Locale.mof (Diff revision 1) 64 uint32 SetLocale(65 [ IN, Description("Locale defines new system locale. It consists "66 "of an array of environment-variable-assignment-like strings. "67 "The following strings are known: \n"68 "LANG=, LC_CTYPE=, LC_NUMERIC=, LC_TIME=, LC_COLLATE=, "69 "LC_MONETARY=, LC_MESSAGES=, LC_PAPER=, LC_NAME=, LC_ADDRESS=, "70 "LC_TELEPHONE=, LC_MEASUREMENT=, LC_IDENTIFICATION=.") ]71 string Locale[]);I don't like this API much, wouldn't it be better to have this values as properties of the object and let user modify them via ModifyInstance method?
+1 to wrong API. There should be Setting attached to something (Linux_OperatingSystem?) and LMI_LocaleService, which would switch current setting with a new one. Also, is there a possibility to get list of all supported locales? It would be nice to have LocaleCapabilities, which would list valid settings.
- Jan
On June 3rd, 2013, 2:01 p.m. CEST, Vitezslav Crhonek wrote:
Review request for OpenLMI Developers.
By Vitezslav Crhonek.
Updated June 3, 2013, 2:01 p.m.
Repository:
openlmi-providers
Description
Diffs
|