This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/839/ |
On September 10th, 2013, 1:34 p.m. CEST, Jan Safranek wrote:
src/hardware/LMI_PCIBridgeProvider.c (Diff revision 1) 83 pci_init(acc);I am not sure how pciutils work, I just assume that it would be better to do pci_init() only once in LMI_PCIBridgeInitialize and maybe share it with multiple providers. And be careful with multiple threads, I don't know how reentrant pciutils are. I am just afraid pci_init might be pretty heavyweight, who knows what it does.
Fixed in https://reviewboard-openlmi.rhcloud.com/r/849/
- Peter
On September 9th, 2013, 8:27 p.m. CEST, Peter Schiffer wrote:
Review request for OpenLMI Developers.
By Peter Schiffer.
Updated Sept. 9, 2013, 8:27 p.m.
Repository:
openlmi-providers
Description
Diffs
|