This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/723/

openlmi-mof-register.py (Diff revision 1) 

    84
    
    devnull = open("/dev/null", "w")

  


 





I think that this shouldn't be here.














 
  

   
    openlmi-mof-register.py
    

     (Diff revision 1)

    
   
  

 



 
 

 

  

    
    

    91
    
    devnull.close()

  


 





I think that this shouldn't be here.














 
  

   
    openlmi-mof-register.py
    

     (Diff revision 1)

    
   
  

 



 
 

 

  

    
    

    155
    
        # fallback solution: most likely things will break

  


  

    
    

    156
    
        log_msg("WARNING: Could not find the Pegasus interop namespace, using root/interop")

  


  

    
    

    157
    
        ret = "root/interop"

  


 





At this point, I think it would be a good idea to exit() with an error message (maybe a broken installation?). Unless Pegasus can have no "root/interop" or "root/PG_InterOp" and still work properly.









- Jan Synacek






On August 15th, 2013, 3:50 p.m. CEST, Tomas Smetana wrote:











 

  


Review request for OpenLMI Developers.


By Tomas Smetana.




Updated Aug. 15, 2013, 3:50 p.m.












 Repository: 
openlmi-providers





Description 

 

 

  
   
Here's a new registration script. It's a merge of the existing openlmi-mof-register and openlmi-register pegasus and should work as drop-in replacement for the openlmi-mof-register. The only slight difference is that the Pegasus interop namespace is not hard coded into the Pegasus registration calls but now there's an attempt to detect the right one.  And the whole thing is now written in (sort of) Python.

This is only the first step in the registration rewrite: Python should make it easier for manipulating a "side database" that would keep the registration data independently of the CIMOMs and eventually allow for re-registration when a new CIMOM is installed or upgraded.  This will also make possible for the providers package not to depend on a CIMOM.  I will prepare some design sketches of the registration process I envision to gather feedback and ideas: doing this correctly and robustly enough is going to be rather difficult.

  		
 







Diffs 


    

 
  • openlmi-mof-register.py (PRE-CREATION)
    • 





View Diff