This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/690/

src/journald/LMI_JournalLogRecordProvider.c (Diff revision 1)
		104	while (CMHasNext(e, &st)) {
		105	cd = CMGetNext(e, &st);
		106	if (st.rc \|\| cd.type != CMPI_ref)
		107	KReturn2(_cb, ERR_FAILED, "Enumerate instances didn't returned list of references");
		108	in = _cb->bft->getInstance(_cb, cc, cd.value.ref, properties, &st);

This results in *lot of* sd_journal_open and sd_journal_seek_cursor calls... is it fast enough?

src/journald/LMI_JournalLogRecordProvider.c (Diff revision 1)
		132	*out = g_strndup(d + strlen(key) + 1, l - strlen(key) - 1);

you should check for NULL and return error

- Jan Safranek

On August 7th, 2013, 4:13 p.m. CEST, Tomáš Bžatek wrote:

Review request for OpenLMI Developers.

By Tomáš Bžatek.

Updated Aug. 7, 2013, 4:13 p.m.

Repository: openlmi-providers

Description

journald: Basic provider implementation

This is a fully functional basic implementation of the provider.

Maximum number of enumerated instances is limited, see the code.

Diffs

CMakeLists.txt (f150e4c77b3cf0475ff906b019da8bdcfab79676)
mof/60_LMI_Journald.mof (PRE-CREATION)
src/CMakeLists.txt (a9dc85d293b82805d4d956f1adbd212c873fd743)
src/journald/CMakeLists.txt (PRE-CREATION)
src/journald/LMI_JournalLogRecordProvider.c (PRE-CREATION)
src/journald/LMI_JournalMessageLogProvider.c (PRE-CREATION)
src/journald/LMI_JournalRecordInLogProvider.c (PRE-CREATION)
src/journald/README (PRE-CREATION)
src/journald/TODO (PRE-CREATION)
src/journald/cmpiLMI_Journald-cimprovagt (PRE-CREATION)
src/journald/instutil.h (PRE-CREATION)
src/journald/instutil.c (PRE-CREATION)
src/journald/journal.h (PRE-CREATION)

View Diff