This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1296/

Ship it!

src/lmi/storage/LMI_LVStorageCapabilities.py (Diff revision 1) 
def create_setting_for_capabilities(self, capabilities):
 

    172
    
            setting['ParityLayout'] = layout_value - 1

  


 





It would be nice to have comment why the -1 is there.









- Radek Novacek






On November 27th, 2013, 12:06 p.m. CET, Jan Safranek wrote:











 

  


Review request for OpenLMI Developers.


By Jan Safranek.




Updated Nov. 27, 2013, 12:06 p.m.












 Repository: 
openlmi-storage





Description 

 

 

  
   
Fixed LMI_LVStorageCapabilities.GetInstance.

Fixing 'TypeError: Null property "ParityLayoutDefault" must have a type',
use proper CIMProperty for Null values.



  		
 







Diffs 


    

 
  • src/lmi/storage/LMI_LVStorageCapabilities.py (cb107cccf6e6b301348d57cb3193673d3ccaf366)
    • 

 
  • test/test_create_lv.py (f28c5764a49dbb8a2f7308eac710fbf9ddd813ab)
    • 

 
  • test/test_create_vg.py (67d08432cbdd3c9b26bb74714382995c7876f5c5)
    • 





View Diff