This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/430/ |
src/locale/localed.c (Diff revision 5) | |||
---|---|---|---|
63 | if ((result = g_dbus_proxy_call_sync(proxy, "Get", g_variant_new("(ss)", LOCALE_INTERFACE, "Locale"), |
Leaking result, use g_variant_unref() to free it (according to documentation).
src/locale/localed.c (Diff revision 5) | |||
---|---|---|---|
67 | g_variant_get(result2, "as", &arr); |
result2 should be also freed explicitly (see https://developer.gnome.org/glib/stable/gvariant-format-strings.html#gvariant-format-strings-variants)
src/locale/localed.c (Diff revision 5) | |||
---|---|---|---|
80 | g_variant_get(result2, "s", &value_str); |
Just realized there's a leak: using Gvariant format string "s" dups memory and you're strdup()-ing it again.
- Tomáš Bžatek
On June 3rd, 2014, 10:25 a.m. UTC, Vitezslav Crhonek wrote:
Review request for OpenLMI Developers.
By Vitezslav Crhonek.
Updated June 3, 2014, 10:25 a.m.
Repository:
openlmi-providers
Description
Diffs
|