This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/430/

On June 3rd, 2014, 1:06 p.m. UTC, Tomáš Bžatek wrote:

src/locale/localed.c (Diff revision 5) 

    80
    
    g_variant_get(result2, "s", &value_str);

  


 




  
Just realized there's a leak: using Gvariant format string "s" dups memory and you're strdup()-ing it again.

 









I removed the strdup().








- Vitezslav






On June 4th, 2014, 10:38 a.m. UTC, Vitezslav Crhonek wrote:












 

  


Review request for OpenLMI Developers.


By Vitezslav Crhonek.




Updated June 4, 2014, 10:38 a.m.












 Repository: 
openlmi-providers





Description 

 

 

  
   
New provider: Locale



  		
 







Diffs 


    

 
  • CMakeLists.txt (bcea09707d1d87db374cf6561d00a19258b54b3b)
    • 

 
  • README (9e7a7abce940c3dea55e0d2a6cf6daed315e8361)
    • 

 
  • mof/60_LMI_Locale.mof (PRE-CREATION)
    • 

 
  • mof/CMakeLists.txt (cbc971b1baa3b9400c644f7abdfc0c272bbabf65)
    • 

 
  • openlmi-providers.spec (dc975d5f0fd169d49227b3749e0fa3f96e5184f9)
    • 

 
  • src/CMakeLists.txt (e0fbb4e05236fc10164f359b5a13f6406aacbda1)
    • 

 
  • src/locale/90_LMI_Locale_Profile.mof.skel (PRE-CREATION)
    • 

 
  • src/locale/CMakeLists.txt (PRE-CREATION)
    • 

 
  • src/locale/LMI_LocaleProvider.c (PRE-CREATION)
    • 

 
  • src/locale/cmpiLMI_Locale-cimprovagt (PRE-CREATION)
    • 

 
  • src/locale/localed.h (PRE-CREATION)
    • 

 
  • src/locale/localed.c (PRE-CREATION)
    • 





View Diff