This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/795/ |
src/account/lock.h (Diff revision 1) | |||
---|---|---|---|
7 | char id[32]; |
I know where the "32" comes from but looking just at the header file it's not that obvious -- try to avoid the magic numbers: give them some name, especially if the same number must be used also somewhere else in the code. #define USERNAME_LEN_MAX 32 ...and use the macro instead.
src/account/lock.c (Diff revision 1) | |||
---|---|---|---|
17 | static void new_pool (void); |
Hm... Maybe I have overlooked something but why isn't new_pool actually defined here?
- Tomas Smetana
On September 2nd, 2013, 11:50 a.m. CEST, Robin Hack wrote:
Review request for OpenLMI Developers.
By Robin Hack.
Updated Sept. 2, 2013, 11:50 a.m.
Repository:
openlmi-providers
Description
Diffs
|