This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1891/

Ship it!

The code looks sane, apart from combining C and C++ style comments. We should only use C-style comments.

cmake/modules/FindPAM.cmake (Diff revision 1) 

    34
    
#if ${HAVE_PAM_PAM_APPL_H}+0

  


 




 


  
Should "PAM" really be there twice?

 









- Jan Synacek






On July 11th, 2014, 12:31 p.m. CEST, Jan Safranek wrote:












 

  


Review request for OpenLMI Developers.


By Jan Safranek.




Updated July 11, 2014, 12:31 p.m.












 Repository: 
openlmi-providers





Description 

 

 

  
   
Add lmipolkitagent

See lmipolkitagent.c for documentation of its purpose.
All the forks and execs were carefuly placed, don't change them without
extensive testing! These parts are hard to debug...

FindPAM.cmake is taken from kde-workspace-4.11.10.tar.xz

  		
 







Diffs 


    

 
  • CMakeLists.txt (f2900abec0ba4b54fed481b7d1390eaed2ba1593)
    • 

 
  • cmake/modules/FindPAM.cmake (PRE-CREATION)
    • 

 
  • src/CMakeLists.txt (0b8a8ff29c7a0c6af4ee2ba0025578c0659f3aa3)
    • 

 
  • src/tools/CMakeLists.txt (PRE-CREATION)
    • 

 
  • src/tools/lmipolkitagent.c (PRE-CREATION)
    • 





View Diff