| This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1760/ |
Ship it!
I don't have a strong opinion about remarks below. Otherwise it looks good to me. Feel free to ship it.
| mof/60_LMI_Journald.mof (Diff revision 1) | |||
|---|---|---|---|
| 228 | [ Implemented(true), Description ( |
||
| 229 | "Denotes numerical effective user ID of the process that sent the " |
||
| 230 | "message. This ID is system specific and usually maps to a local " |
||
| 231 | "POSIX account." ) ] |
||
| 232 | sint32 UserID; |
||
| 233 | |||
| 234 | [ Implemented(true), Description ( |
||
| 235 | "Denotes numerical effective group ID of the process that sent the " |
||
| 236 | "message. This ID is system specific and usually maps to a local " |
||
| 237 | "POSIX account." ) ] |
||
| 238 | sint32 GroupID; |
||
| 239 | |||
| 240 | [ Implemented(true), Description ( |
||
| 241 | "Denotes numerical ID of the process that sent the message." ) ] |
||
| 242 | uint32 ProcessID; |
||
Having 2 IDs signed and one unsigned looks weird. If I take a look at CIM schema, UserID and GroupID properties are strings but there's also CIM_UnixProcess with RealUserID and RealGroupID. They are uint64 properties.
IMHO in this case there's no harm in sticking to CIM convention.
| mof/60_LMI_Journald.mof (Diff revision 1) | |||
|---|---|---|---|
| 250 | Values { "kern", "user", "mail", "daemon", "auth", "syslog", "lpr", |
||
| 251 | "news", "uucp", "clock", "authpriv", "ftp", "ntp", "audit", |
||
| 252 | "alert", "cron", "local0", "local1", "local2", "local3", |
||
| 253 | "local4", "local5", "local6", "local7" } ] |
||
I don't know much about logging facilities, but is this information always known? I'm missing something like "unknown" in possible values.
- Michal Minar
On květen 22nd, 2014, 3:36 odp. UTC, Tomáš Bžatek wrote:
|
Review request for OpenLMI Developers.
By Tomáš Bžatek.
Updated Kvě. 22, 2014, 3:36 odp.
Repository:
openlmi-providers
Description
Diffs
|