This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/470/ |
mof/60_LMI_Account.mof (Diff revision 1) | |||
---|---|---|---|
322 | class LMI_AccountInstanceDeletionIndication: CIM_InstCreation |
Shouldn't parent class be CIM_InstDeletion?
src/account/CMakeLists.txt (Diff revision 1) | |||
---|---|---|---|
40 | include_directories(${CMAKE_CURRENT_BINARY_DIR} ${CMPI_INCLUDE_DIR} ${LIBUSER_INCLUDE_DIRS}) |
42 | include_directories(${CMAKE_CURRENT_BINARY_DIR} ${CMPI_INCLUDE_DIR} ${LIBUSER_INCLUDE_DIRS}) |
41 | 43 | ||
42 | target_link_libraries(${LIBRARY_NAME} openlmicommon ${KONKRETCMPI_LIBRARIES} ${LIBUSER_LIBRARIES}) |
44 | target_link_libraries(${LIBRARY_NAME} openlmicommon ${KONKRETCMPI_LIBRARIES} ${LIBUSER_LIBRARIES}) |
43 | 45 | ||
46 | |||
47 | include_directories(${CMAKE_CURRENT_BINARY_DIR} ${CMPI_INCLUDE_DIR} ${IM_INCLUDE_DIRS}) |
||
48 | |||
49 | target_link_libraries(${LIBRARY_NAME} openlmicommon ${KONKRETCMPI_LIBRARIES} ${IM_LIBRARIES}) |
||
50 |
This looks like that include_directories and target_link_libraries are here twice. Why?
src/account/LMI_AccountInstanceCreationIndicationProvider.c (Diff revision 1) | |||
---|---|---|---|
37 | IM_IND_CREATION, (CMPIBroker *)_cb, &im_err); |
The cast to (CMPIBroker *) shouldn't be required any more, im_create_manager now takes (const CMPIBroker *).
- Radek Novacek
On June 26th, 2013, 4:42 p.m. CEST, Roman Rakus wrote:
Review request for OpenLMI Developers.
By Roman Rakus.
Updated June 26, 2013, 4:42 p.m.
Repository:
openlmi-providers
Description
Diffs
|