This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/915/

Ship it!

Cosmetics. Ship it!

openlmi-mof-register.py (Diff revision 1) 
def list_db():
 

    535
    
        log_msg('Registering mofs: ' + " ".join(mofs) + ", reg: " + str(reg))

  


 





I'd replace apostrophes with double quotes for consistency.














 
  

   
    openlmi-mof-register.py
    

     (Diff revision 1)

    
   
  

 

 
  


   
def list_db():


  

 



 
 

 

  

    
    

    539
    
        log_msg('Unregistering mofs: ' + " ".join(mofs) + ", reg: " + str(reg))

  


 





I'd replace apostrophes with double quotes for consistency.














 
  

   
    openlmi-mof-register.py
    

     (Diff revision 1)

    
   
  

 

 
  


   
def list_db():


  

 



 
 

 

  

    
    

    543
    
        log_msg('Re-registering mofs: ' + " ".join(mofs) + ", reg: " + str(reg))

  


 





I'd replace apostrophes with double quotes for consistency.









- Jan Synacek






On October 2nd, 2013, 12:43 p.m. CEST, Tomas Smetana wrote:











 

  


Review request for OpenLMI Developers.


By Tomas Smetana.




Updated Oct. 2, 2013, 12:43 p.m.












 Repository: 
openlmi-providers





Description 

 

 

  
   
This is an aggregate patch (sorry) of several issues I have discovered in the new registration script:

- Print usage when invoked with no arguments
- Fix SQL parameters bindings: use tuples properly
- Fix querying of registrations with no REG file
- Log the "main" action before it's actually performed for better logs readability

  		
 







Diffs 


    

 
  • openlmi-mof-register.py (bac1e2393e09826983f32bade4f45cc342290e00)
    • 





View Diff