This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/444/

test/test_mounting.py (Diff revision 1) 

    28
    
    def setUp(self):

  


 





You should probably create a filesystem on some device (self.partitions?) here, so you have something to mount. . Feel free to call cmdline utilities directly. Calling LMI methods to create a fs would be nice to have.

Expecting that it's already provided in environ. variable is imho bad, the test already got list of devices it can use, so let the test set up the filesystems by itself.

And please test various filesystems, not only ext4.














 
  

   
    test/test_mounting.py
    

     (Diff revision 1)

    
   
  

 



 
 

 

  

    
    

    35
    
        pass

  


 





missing super(TestMounting, self).tearDown














 
  

   
    test/test_mounting.py
    

     (Diff revision 1)

    
   
  

 



 
 

 

  

    
    

    66
    
        # XXX outparams is always {} here, even though mounting was successful. BUG?

  


 





That's probably because of (known) bug in Pegasus.









- Jan Safranek






On June 12th, 2013, 11:15 a.m. CEST, Jan Synacek wrote:











 

  


Review request for OpenLMI Developers.


By Jan Synacek.




Updated June 12, 2013, 11:15 a.m.












 Repository: 
openlmi-storage





Description 

 

 

  
   
Add mounting tests.



  		
 







Diffs 


    

 
  • test/test_base.py (bc5c6c83ebbce67483a3179f7d43068d601d3fea)
    • 

 
  • test/test_mounting.py (PRE-CREATION)
    • 





View Diff