This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/430/

Autoscan finished with errors:
Error: RESOURCE_LEAK (CWE-772):
openlmi-providers-0.4.1_314_gb904d5b/src/locale/LMI_LocaleProvider.c:94: alloc_fn: Storage is returned from allocation function "locale_get_properties(void)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:60:5: alloc_fn: Storage is returned from allocation function "malloc(size_t)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:60:5: var_assign: Assigning: "cloc" = "malloc(160UL)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:133:5: return_alloc: Returning allocated memory "cloc".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/LMI_LocaleProvider.c:94: var_assign: Assigning: "cloc" = storage returned from "locale_get_properties()".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/LMI_LocaleProvider.c:130: leaked_storage: Variable "cloc" going out of scope leaks the storage it points to.

Error: UNINIT (CWE-457):
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:53: var_decl: Declaring variable "cloc".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:60: alloc_fn: Calling allocator "malloc(size_t)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:60: assign: Assigning: "cloc" = "malloc(160UL)", which is allocated but not initialized.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:138: uninit_use_in_call: Using uninitialized value "cloc->X11Options" when calling "locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:156:5: read_parm_fld: Reading a parameter field.

Error: UNINIT (CWE-457):
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:53: var_decl: Declaring variable "cloc".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:60: alloc_fn: Calling allocator "malloc(size_t)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:60: assign: Assigning: "cloc" = "malloc(160UL)", which is allocated but not initialized.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:138: uninit_use_in_call: Using uninitialized value "cloc->X11Variant" when calling "locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:155:5: read_parm_fld: Reading a parameter field.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:138: uninit_use_in_call: Using uninitialized value "cloc->X11Options" when calling "locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:156:5: read_parm_fld: Reading a parameter field.

Error: UNINIT (CWE-457):
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:53: var_decl: Declaring variable "cloc".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:60: alloc_fn: Calling allocator "malloc(size_t)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:60: assign: Assigning: "cloc" = "malloc(160UL)", which is allocated but not initialized.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:138: uninit_use_in_call: Using uninitialized value "cloc->X11Model" when calling "locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:154:5: read_parm_fld: Reading a parameter field.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:138: uninit_use_in_call: Using uninitialized value "cloc->X11Variant" when calling "locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:155:5: read_parm_fld: Reading a parameter field.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:138: uninit_use_in_call: Using uninitialized value "cloc->X11Options" when calling "locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:156:5: read_parm_fld: Reading a parameter field.

Error: UNINIT (CWE-457):
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:53: var_decl: Declaring variable "cloc".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:60: alloc_fn: Calling allocator "malloc(size_t)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:60: assign: Assigning: "cloc" = "malloc(160UL)", which is allocated but not initialized.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:138: uninit_use_in_call: Using uninitialized value "cloc->X11Layouts" when calling "locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:153:5: read_parm_fld: Reading a parameter field.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:138: uninit_use_in_call: Using uninitialized value "cloc->X11Model" when calling "locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:154:5: read_parm_fld: Reading a parameter field.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:138: uninit_use_in_call: Using uninitialized value "cloc->X11Variant" when calling "locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:155:5: read_parm_fld: Reading a parameter field.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:138: uninit_use_in_call: Using uninitialized value "cloc->X11Options" when calling "locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:156:5: read_parm_fld: Reading a parameter field.

Error: UNINIT (CWE-457):
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:53: var_decl: Declaring variable "cloc".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:60: alloc_fn: Calling allocator "malloc(size_t)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:60: assign: Assigning: "cloc" = "malloc(160UL)", which is allocated but not initialized.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:138: uninit_use_in_call: Using uninitialized value "cloc->VConsoleKeymapToggle" when calling "locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:152:5: read_parm_fld: Reading a parameter field.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:138: uninit_use_in_call: Using uninitialized value "cloc->X11Layouts" when calling "locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:153:5: read_parm_fld: Reading a parameter field.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:138: uninit_use_in_call: Using uninitialized value "cloc->X11Model" when calling "locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:154:5: read_parm_fld: Reading a parameter field.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:138: uninit_use_in_call: Using uninitialized value "cloc->X11Variant" when calling "locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:155:5: read_parm_fld: Reading a parameter field.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:138: uninit_use_in_call: Using uninitialized value "cloc->X11Options" when calling "locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:156:5: read_parm_fld: Reading a parameter field.

Error: UNINIT (CWE-457):
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:53: var_decl: Declaring variable "cloc".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:60: alloc_fn: Calling allocator "malloc(size_t)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:60: assign: Assigning: "cloc" = "malloc(160UL)", which is allocated but not initialized.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:138: uninit_use_in_call: Using uninitialized element of array "cloc->Locale" when calling "locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:150:43: read_parm_fld: Reading a parameter field.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:138: uninit_use_in_call: Using uninitialized value "cloc->VConsoleKeymap" when calling "locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:151:5: read_parm_fld: Reading a parameter field.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:138: uninit_use_in_call: Using uninitialized value "cloc->VConsoleKeymapToggle" when calling "locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:152:5: read_parm_fld: Reading a parameter field.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:138: uninit_use_in_call: Using uninitialized value "cloc->X11Layouts" when calling "locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:153:5: read_parm_fld: Reading a parameter field.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:138: uninit_use_in_call: Using uninitialized value "cloc->X11Model" when calling "locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:154:5: read_parm_fld: Reading a parameter field.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:138: uninit_use_in_call: Using uninitialized value "cloc->X11Variant" when calling "locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:155:5: read_parm_fld: Reading a parameter field.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:138: uninit_use_in_call: Using uninitialized value "cloc->X11Options" when calling "locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:156:5: read_parm_fld: Reading a parameter field.

Error: UNINIT (CWE-457):
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:53: var_decl: Declaring variable "cloc".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:60: alloc_fn: Calling allocator "malloc(size_t)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:60: assign: Assigning: "cloc" = "malloc(160UL)", which is allocated but not initialized.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:138: uninit_use_in_call: Using uninitialized value "cloc->VConsoleKeymap" when calling "locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:151:5: read_parm_fld: Reading a parameter field.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:138: uninit_use_in_call: Using uninitialized value "cloc->VConsoleKeymapToggle" when calling "locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:152:5: read_parm_fld: Reading a parameter field.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:138: uninit_use_in_call: Using uninitialized value "cloc->X11Layouts" when calling "locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:153:5: read_parm_fld: Reading a parameter field.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:138: uninit_use_in_call: Using uninitialized value "cloc->X11Model" when calling "locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:154:5: read_parm_fld: Reading a parameter field.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:138: uninit_use_in_call: Using uninitialized value "cloc->X11Variant" when calling "locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:155:5: read_parm_fld: Reading a parameter field.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:138: uninit_use_in_call: Using uninitialized value "cloc->X11Options" when calling "locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:156:5: read_parm_fld: Reading a parameter field.

Error: CLANG_WARNING:
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:151:9: warning: Branch condition evaluates to a garbage value
#    if (cloc->VConsoleKeymap) free(cloc->VConsoleKeymap);
#        ^~~~~~~~~~~~~~~~~~~~

Error: CLANG_WARNING:
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:152:9: warning: Branch condition evaluates to a garbage value
#    if (cloc->VConsoleKeymapToggle) free(cloc->VConsoleKeymapToggle);
#        ^~~~~~~~~~~~~~~~~~~~~~~~~~

Error: CLANG_WARNING:
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:153:9: warning: Branch condition evaluates to a garbage value
#    if (cloc->X11Layouts) free(cloc->X11Layouts);
#        ^~~~~~~~~~~~~~~~

Error: CLANG_WARNING:
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:154:9: warning: Branch condition evaluates to a garbage value
#    if (cloc->X11Model) free(cloc->X11Model);
#        ^~~~~~~~~~~~~~

Error: CLANG_WARNING:
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:155:9: warning: Branch condition evaluates to a garbage value
#    if (cloc->X11Variant) free(cloc->X11Variant);
#        ^~~~~~~~~~~~~~~~

Error: CLANG_WARNING:
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:156:9: warning: Branch condition evaluates to a garbage value
#    if (cloc->X11Options) free(cloc->X11Options);
#        ^~~~~~~~~~~~~~~~

Scanned reviews: 430

- scanbot


On May 29th, 2014, 7:12 a.m. UTC, Vitezslav Crhonek wrote:

Review request for OpenLMI Developers.
By Vitezslav Crhonek.

Updated May 29, 2014, 7:12 a.m.

Repository: openlmi-providers

Description

New provider: Locale

Diffs

  • CMakeLists.txt (bcea09707d1d87db374cf6561d00a19258b54b3b)
  • README (9e7a7abce940c3dea55e0d2a6cf6daed315e8361)
  • mof/60_LMI_Locale.mof (PRE-CREATION)
  • mof/CMakeLists.txt (cbc971b1baa3b9400c644f7abdfc0c272bbabf65)
  • openlmi-providers.spec (dc975d5f0fd169d49227b3749e0fa3f96e5184f9)
  • src/CMakeLists.txt (e0fbb4e05236fc10164f359b5a13f6406aacbda1)
  • src/locale/90_LMI_Locale_Profile.mof.skel (PRE-CREATION)
  • src/locale/CMakeLists.txt (PRE-CREATION)
  • src/locale/LMI_LocaleProvider.c (PRE-CREATION)
  • src/locale/cmpiLMI_Locale-cimprovagt (PRE-CREATION)
  • src/locale/localed.h (PRE-CREATION)
  • src/locale/localed.c (PRE-CREATION)

View Diff