This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1291/

Autoscan finished with errors:
Error: LOCK (CWE-667):
openlmi-providers-0.4.1_62_g4d87f52/src/indmanager/ind_manager.c:1211: lock: "pthread_mutex_lock(pthread_mutex_t *)" locks "manager->_t_mutex".
openlmi-providers-0.4.1_62_g4d87f52/src/indmanager/ind_manager.c:1214: missing_unlock: Returning without unlocking "manager->_t_mutex".

Scanned reviews: 1290,1291

- scanbot


On November 26th, 2013, 12:04 p.m. UTC, Jan Safranek wrote:

Review request for OpenLMI Developers.
By Jan Safranek.

Updated Nov. 26, 2013, 12:04 p.m.

Repository: openlmi-providers

Description

indicationmgr: fixed deadlock when re-starting the namager thread.

When the indication manager thread was stopped, it destroys its mutex and
creates new one. If pthread_mutex_destroy() fails because the mutex is
locked, the new mutex is not created -> the old one is used, but it's already
locked -> deadlock.

So let's make sure the mutex is unlocked when destroying the thread.

Rewrite of indication manager thread is needed to have the manage() function
interruptible when waiting for events, e.g. using a pipe and select(),
this pthread_cancel leads to memory leaks.

Diffs

  • src/indmanager/ind_manager.c (7d6bc7545647589178ed2a858c0d136c4806b7b0)

View Diff