This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/897/ |
On September 30th, 2013, 1:54 p.m. CEST, Radek Novacek wrote:
src/account/LMI_GroupProvider.c (Diff revision 1) static CMPIStatus LMI_GroupDeleteInstance(143 const CMPIResult* cr,148 static CMPIrc delete_group(Wouldn't it be better to return CMPIStatus - it contains both RC and error string?On September 30th, 2013, 2:18 p.m. CEST, Roman Rakus wrote:
I don't see any gain here...
The gain is that you wouldn't need to convert it to CMPIStatus anyway in the caller. But it's up to you...
- Radek
On September 30th, 2013, 2:18 p.m. CEST, Roman Rakus wrote:
Review request for OpenLMI Developers.
By Roman Rakus.
Updated Sept. 30, 2013, 2:18 p.m.
Repository:
openlmi-providers
Description
Diffs
|