On July 23rd, 2013, 11:53 a.m. CEST, Jan Safranek wrote:

src/lmi/storage/LMI_ExtentEncryptionConfigurationService.py (Diff revision 1)
		133	except:
		134	rval = self.CreateEncryptionFormat.Failed
		135	state = Job.STATE_FAILED
		136	err = pywbem.CIMError(pywbem.CIM_ERR_FAILED,
		137	"Can't format LUKS device.")

I usually let all blivet exceptions pass through, they are caught by job processor, which then shows error string from the exception (-> usually stderr of cmdline), which is sometimes more useful than generic "Can't format LUKS".

In that case, I don't have to care about the job's return value, state and the return error. If that is true, Job.finish_method() doesn't have to have those as well. Is that right or am I missing something?

- Jan

On July 22nd, 2013, 9:57 a.m. CEST, Jan Synacek wrote:

Add LUKS version 1.

Only LMI_LUKSFormat and LMI_ExtentEncryptionConfigurationService are
implemented. Howerever, these two classes add most of the LUKS
functionality. Setting and Capability classes were omitted.