I am not sure how pciutils work, I just assume that it would be better to do pci_init() only once in LMI_PCIBridgeInitialize and maybe share it with multiple providers. And be careful with multiple threads, I don't know how reentrant pciutils are.
I am just afraid pci_init might be pretty heavyweight, who knows what it does.
- Jan Safranek
On September 9th, 2013, 8:27 p.m. CEST, Peter Schiffer wrote:
|
Review request for OpenLMI Developers.
By Peter Schiffer.
Updated Sept. 9, 2013, 8:27 p.m.
Repository:
openlmi-providers
Description
Hardware: Added PCI_Bridge provider
[SORRY - I've already pushed this commit to the git by mistake..]
Separated PCI_Bridges from PCI_Devices and provided multiple additional
information related to PCI_Bridges.
New providers:
* LMI_PCIBridgeProvider
* LMI_PCIBridgeSystemDeviceProvider
|
Diffs
- mof/60_LMI_Hardware.mof (d712b9076969652184769ccad1b2f6689dbf131a)
- src/hardware/90_LMI_Hardware_Profile_DMTF.mof (777fa909d80c68279484e5b98b7102634ec3a09d)
- src/hardware/CMakeLists.txt (8089a08e46c79baa1d564dec3f660ab292db245c)
- src/hardware/LMI_Hardware.h (e72536a7414161958b0206e373d1d810d2d930f1)
- src/hardware/LMI_PCIBridgeProvider.c (PRE-CREATION)
- src/hardware/LMI_PCIBridgeSystemDeviceProvider.c (PRE-CREATION)
- src/hardware/LMI_PCIDeviceProvider.c (a88f9cd89df54760c813292194e7859dd9ba2e1c)
- src/hardware/LMI_PCIDeviceSystemDeviceProvider.c (e473ddfa6dd19e956edb85380fdc6d8ae3485280)
- src/hardware/PCIDev.h (PRE-CREATION)
- src/hardware/PCIDev.c (PRE-CREATION)
View Diff
|