This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1741/

src/account/test/TestIndicationEventStream.py (Diff revision 1) 

    37
    
            'conn': self.conn,

  


  

    
    

    38
    
            'delay_action': 0.1,

  


  

    
    

    39
    
            'delay_chillout': 3,

  


  

    
    

    40
    
            'listener_host': "localhost",

  


  

    
    

    41
    
            'listener_port': 11001,

  


 





Most of these seem like common options to many other tests. I'd try to move them somewhere higher in hierarchy to lmi.test package. It would make sense to let them be overridden by environment variables.

Also name *options* is not much descriptive - especially since they are not used anywhere in this module (except of being modified in few tests).














 
  

   
    src/account/test/TestIndicationEventStream.py
    

     (Diff revision 1)

    
   
  

 



 
 

 

  

    
    

    127
    
    def xtest_create_50(self):

  


 





Why the leading 'x'?
IMHO it prevents the test from being discovered and run.














 
  

   
    src/account/test/TestIndicationEventStream.py
    

     (Diff revision 1)

    
   
  

 



 
 

 

  

    
    

    133
    
        self.options['delay_chillout'] = 20

  


 





Since the order of tests execution is not deterministic, this assignment nondeterministically affect other tests which do not modify options. Maybe this option could be passed as a keyword argument to self.assertExpectedStream that would treat them as additional options to driver.









- Michal Minar






On May 14th, 2014, 4:31 p.m. UTC, Alois Mahdal wrote:











 

  


Review request for OpenLMI Developers.


By Alois Mahdal.




Updated May 14, 2014, 4:31 p.m.












 Repository: 
openlmi-providers





Description 

 

 

  
   
Basic set of tests with focus on this flow:

  1. add set of subscriptions
  2. add set of handlers
  3. trigger sequence of "interesting" events
  4. collect indications
  5. and make assertions as needed

Currently the assertions are mostly that correct classes have been
delivered, reporting the events in correct order.

  		
 







Diffs 


    

 
  • src/account/test/TestIndicationEventStream.py (PRE-CREATION)
    • 





View Diff