This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/439/

On June 11th, 2013, 10:40 a.m. CEST, Jan Synacek wrote:

src/LMI_NetworkInstCreationProvider.c (Diff revision 1) 

    149
    
        CMReturn(CMPI_RC_ERR_FAILED);

  


 




  
IMO the program should just die (exit) after a malloc fails.

Not an issue, just a thought.

 









I don't think provider should ever die. We would need to check if CIMOM handles it properly (replies to client request, restarts the provider). Sometimes the malloc failure is not even fatal.








- Radek






On June 10th, 2013, 1:45 p.m. CEST, Radek Novacek wrote:











 

  


Review request for OpenLMI Developers.


By Radek Novacek.




Updated June 10, 2013, 1:45 p.m.












 Repository: 
openlmi-networking





Description 

 

 

  
   
Add Lifetime indication

Lifetime indication for classes IPNetworkConnection and
IPAssignmentSettingData.


  		
 







Diffs 


    

 
  • mof/LMI_Networking.mof (30e7312c2c764e059c335d525d51c80df2b72943)
    • 

 
  • src/CMakeLists.txt (793d9547dcdb575070529296178ba9f81f3fc2ac)
    • 

 
  • src/LMI_NetworkInstCreationProvider.c (PRE-CREATION)
    • 

 
  • src/LMI_NetworkInstDeletionProvider.c (PRE-CREATION)
    • 

 
  • src/LMI_NetworkInstModificationProvider.c (PRE-CREATION)
    • 

 
  • src/connection_nm.c (b664ca2c13091f567d6228b5ce3c595758edecec)
    • 

 
  • src/indications.h (PRE-CREATION)
    • 

 
  • src/indications.c (PRE-CREATION)
    • 

 
  • src/network.h (27577dd4d8fd7be278decd5e6ae251063935f08f)
    • 

 
  • src/network.c (607bd834709a86c8bfe51ac9122d0842b23b1cd9)
    • 

 
  • src/network_nm.c (6d2eacf805dba3dd64e20f3eeae0b69bd49c170a)
    • 

 
  • src/network_private.h (a5c08c3350514816dc859fc9ead09ad422e5bac6)
    • 

 
  • src/port_nm.c (5da6eba639823d133f07e5170b72b4337a679069)
    • 





View Diff