This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/430/

mof/60_LMI_Locale.mof (Diff revision 1)
64
    uint32 SetLocale(
65
        [ IN, Description("Locale defines new system locale. It consists "
66
            "of an array of environment-variable-assignment-like strings. "
67
            "The following strings are known: \n"
68
            "LANG=, LC_CTYPE=, LC_NUMERIC=, LC_TIME=, LC_COLLATE=, "
69
            "LC_MONETARY=, LC_MESSAGES=, LC_PAPER=, LC_NAME=, LC_ADDRESS=, "
70
            "LC_TELEPHONE=, LC_MEASUREMENT=, LC_IDENTIFICATION=.") ]
71
        string Locale[]);
I don't like this API much, wouldn't it be better to have this values as properties of the object and let user modify them via ModifyInstance method?

mof/60_LMI_Locale.mof (Diff revision 1)
72
//  Parameter bellow is not useful for our purpose - it's hardcoded
73
//  to FALSE in the locale provider.
74
//        [ IN, Description("UserInteractive can be used to control "
75
//            "whether PolicyKit should interactively ask the user for "
76
//            "authentication credentials if it needs to.")) ]
77
//        boolean UserInteractive);
Why is this comment here if it's not used?

src/locale/LMI_LocaleProvider.c (Diff revision 1)
68
    LMI_Locale_Set_VConsoleKeymap(&w, cloc->VConsoleKeymap);
69
    LMI_Locale_Set_VConsoleKeymap(&w, cloc->VConsoleKeymap);
Why is this line here twice?

- Radek


On June 3rd, 2013, 2:01 p.m. CEST, Vitezslav Crhonek wrote:

Review request for OpenLMI Developers.
By Vitezslav Crhonek.

Updated June 3, 2013, 2:01 p.m.

Repository: openlmi-providers

Description

New provider: Locale

Diffs

  • CMakeLists.txt (c5a5c7c8fd1b24f76c4953e8a3cc8257bbe58d8e)
  • README (a80a1d2624c80367ed53e06f50804ed39b3103da)
  • mof/60_LMI_Locale.mof (PRE-CREATION)
  • openlmi-providers.spec (6e75e6f8332df807be4c2c5260211fce3339db89)
  • src/CMakeLists.txt (27bd416e1545725af0975e806975ca2119b4388b)
  • src/locale/CMakeLists.txt (PRE-CREATION)
  • src/locale/LMI_LocaleProvider.c (PRE-CREATION)
  • src/locale/localed.h (PRE-CREATION)
  • src/locale/localed.c (PRE-CREATION)

View Diff