This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/795/ |
On September 2nd, 2013, 12:32 p.m. CEST, Jan Synacek wrote:
Also, please use whitespaces consistently. That means write strcmp(something, here) instead of strcmp ( something, here ).On September 2nd, 2013, 12:35 p.m. CEST, Jan Synacek wrote:
One more thing, you should also probably respect the if structure indentation used in the provider. It uses the gnu style if () { /* code here */ }On September 2nd, 2013, 1:25 p.m. CEST, Jan Safranek wrote:
Well, I would rather rewrite the account provider to adapt to rest of the providers, see https://fedorahosted.org/openlmi/wiki/CodingConventions
Yes, that would be ideal.
- Jan
On September 2nd, 2013, 11:50 a.m. CEST, Robin Hack wrote:
Review request for OpenLMI Developers.
By Robin Hack.
Updated Sept. 2, 2013, 11:50 a.m.
Repository:
openlmi-providers
Description
Diffs
|