This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/795/

src/account/lock.c (Diff revision 1) 

    10
    
#define UNLOCK_CSEC() do { pthread_mutex_unlock (&pool->csec); } while (0) 

  


 





Whitespace be-gone.














 
  

   
    src/account/lock.c
    

     (Diff revision 1)

    
   
  

 



 
 

 

  

    
    

    25
    
        // fail

  


 





There seems to be a missing piece of code here.














 
  

   
    src/account/lock.c
    

     (Diff revision 1)

    
   
  

 



 
 

 

  

    
    

    143
    
            // fail - how?

  


 





Code missing.














 
  

   
    src/account/lock.c
    

     (Diff revision 1)

    
   
  

 



 
 

 

  

    
    

    159
    
int unleash_lock (const char *const username)

  


 





I wouldn't call releasing a lock 'unleashing'. Why not release_lock?














 
  

   
    src/account/lock.c
    

     (Diff revision 1)

    
   
  

 



 
 

 

  

    
    

    190
    
    

  


 





Whitespace be-gone.








 
Also, please use whitespaces consistently. That means write strcmp(something, here) instead of strcmp ( something, here ).



- Jan Synacek






On September 2nd, 2013, 11:50 a.m. CEST, Robin Hack wrote:











 

  


Review request for OpenLMI Developers.


By Robin Hack.




Updated Sept. 2, 2013, 11:50 a.m.












 Repository: 
openlmi-providers





Description 

 

 

  
   
Account: Added associative thread locking.

Missing files included.


  		
 







Diffs 


    

 
  • src/account/CMakeLists.txt (495d7c6e3e1e083541d3ed004518dc4539f61d48)
    • 

 
  • src/account/LMI_AccountProvider.c (5abad7261331c429de0503b8bfb9f8fc180141cf)
    • 

 
  • src/account/lock.h (PRE-CREATION)
    • 

 
  • src/account/lock.c (PRE-CREATION)
    • 





View Diff