This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/830/

On September 9th, 2013, 6:57 a.m. UTC, Michal Minar wrote:

cli/completion/lmishell.bash (Diff revision 1)
26
    local options=(-h -i -v -m -q -n --help --interactive --verbose --more-verbose --quiet --noverify)
s/interactive/interact/
oh... good catch

On September 9th, 2013, 6:57 a.m. UTC, Michal Minar wrote:

cli/completion/lmishell.bash (Diff revision 1)
36
            COMPREPLY=( $(compgen -f -o plusdirs -X '!*.lmi' -- "$current") )
Shouldn't *.py files complete as well?
That's a question. Not a problem to add it. What others think about it?

- Roman


On September 6th, 2013, 10:31 a.m. UTC, Roman Rakus wrote:

Review request for OpenLMI Developers.
By Roman Rakus.

Updated Sept. 6, 2013, 10:31 a.m.

Repository: openlmi-tools

Description

Completion: bash completion for lmi shell

It allow to complete:
- LMI Shell options (short and long)
- files with .lmi extension
- directories

Signed-off-by: Roman Rakus <rrakus@redhat.com>

Testing

This is my very first completion, so please test it. It should properly handle files with spaces. It allow to complete lmishell options, but only if they are before file name.

Diffs

  • cli/completion/lmishell.bash (PRE-CREATION)

View Diff