This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1896/

cli/lmi/shell/LMIMethod.py (Diff revision 1)
def __return_synchro_method_call(self, job_inst, job_refresh=True):
210
                if (    self._method.parameters.has_key(k)
211
                   and (  self._method.parameters[k].qualifiers is None
212
                       or self._method.parameters[k].qualifiers.get(

I am OK with the code; but please, don't use this style of indenting.


- Peter Hatina


On July 14th, 2014, 7:37 a.m. UTC, Michal Minar wrote:

Review request for OpenLMI Developers.
By Michal Minar.

Updated July 14, 2014, 7:37 a.m.

Repository: openlmi-tools

Description

shell: better handle job output parameters

Due to openlmi's workaround of pegasus' shortcoming, JobOutParameters
property of job instance is something else then it should be. It's an
instance of __MethodParameters_<method_name>_Result class which derives
from __MethodParameters_<method_name> class. The latter contains input
parameters of asynchronous method. Therefor JobOutParameters may contain
input parameters as well. Let's filter them out because this may confuse
client scripts.

Diffs

  • cli/lmi/shell/LMIMethod.py (97b8cb66066ec968c0b05e72de0e7074482abdcb)

View Diff