| This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/430/ |
| src/locale/localed.c (Diff revision 1) | |||
|---|---|---|---|
| 144 | if (cloc->VConsoleKeymap) free(cloc->VConsoleKeymap); |
||
| 145 | if (cloc->VConsoleKeymapToggle) free(cloc->VConsoleKeymapToggle); |
||
| 146 | if (cloc->X11Layout) free(cloc->X11Layout); |
||
| 147 | if (cloc->X11Model) free(cloc->X11Model); |
||
| 148 | if (cloc->X11Variant) free(cloc->X11Variant); |
||
| 149 | if (cloc->X11Options) free(cloc->X11Options); |
||
It's not necessary to check for NULL. free(NULL) is NOP. Maybe rather check if(clock), if clock isn't NULL.
- Roman
On June 3rd, 2013, 12:01 p.m. UTC, Vitezslav Crhonek wrote:
|
Review request for OpenLMI Developers.
By Vitezslav Crhonek.
Updated June 3, 2013, 12:01 p.m.
Repository:
openlmi-providers
Description
Diffs
|