This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/583/

On August 16th, 2013, 9:49 a.m. CEST, Jan Safranek wrote:

Overall, it looks really well done. Just LMI_StorageExtent.provides_device() needs an update (don't you see 2 CIM_StorageExtents for opened LUKS device? One LMI_StorageExtent and second LMI_LUKSStorageExtent).

Also, I miss LMI_LUKSBasedOn association between the device with LUKS format and opened LUKS device, see LMI_MDRAIDBasedOn for inspiration, but that can be separate patch.
LMI_StorageExtent.provides_device() updated. I'll post LMI_LUKSBasedOn as a separate patch.

- Jan


On August 14th, 2013, 2:55 p.m. CEST, Jan Synacek wrote:

Review request for OpenLMI Developers.
By Jan Synacek.

Updated Aug. 14, 2013, 2:55 p.m.

Repository: openlmi-storage

Description 

Add LUKS version 1.

Only LMI_LUKSFormat and LMI_ExtentEncryptionConfigurationService are
implemented. Howerever, these two classes add most of the LUKS
functionality. Setting and Capability classes were omitted.

Diffs

  • mof/LMI_Storage-JobResult.mof (42051181aa2d78bd84c9ec7274bea1b75ef9de04)
  • mof/LMI_Storage-Luks.mof (3b7ba8e4fd000acdb1cf4232b8ec18120c4a5029)
  • mof/LMI_Storage.reg (cf690b166800bd3e4d15da506d86e60777215080)
  • src/lmi/storage/FormatProvider.py (79c61fa08688db3d1c636fdd7c36a6c518d74255)
  • src/lmi/storage/LMI_ExtentEncryptionConfigurationService.py (PRE-CREATION)
  • src/lmi/storage/LMI_LUKSFormat.py (PRE-CREATION)
  • src/lmi/storage/LMI_LUKSStorageExtent.py (PRE-CREATION)
  • src/lmi/storage/ProviderManager.py (3885c7d255694e659b9ccfa0de93550639b26897)
  • src/lmi/storage/cimom_entry.py (753aa4e9172734eb6caf280619d9d3a9b576daea)

View Diff