This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1172/

mof/60_LMI_Hardware.mof (Diff revision 1)
		457	[ Version("0.2.0"), Provider("cmpi:cmpiLMI_DiskPhysicalPackage") ]

Version("0.2.0") -> Version("0.4.1")

mof/60_LMI_Hardware.mof (Diff revision 1)
		458	class LMI_DiskPhysicalPackage: CIM_PhysicalPackage
		459	{
		460	};

Consider using Implemented("True") qualifier for all properties supported. These properties are then nicely accessible from LMI_* classes in our documentation.

src/hardware/sysfs.h (Diff revision 1)
typedef struct _SysfsCpuCache {
	62	/*
	63	* Read unsigned value from file.
	64	* @param path of file
	65	* @paratm result
	66	* @return 0 if success, negative value otherwise
	67	*/
	68	short path_get_unsigned(const char path, unsigned result);
	69
	70	/*
	71	* Read string value from file.
	72	* @param path of file
	73	* @paratm result
	74	* @return 0 if success, negative value otherwise
	75	*/
	76	short path_get_string(const char path, char *result);

Make a separate patch for unrelated changes  next time.

- Michal Minar

On October 31st, 2013, 3:58 p.m. UTC, Peter Schiffer wrote:

Review request for OpenLMI Developers.

By Peter Schiffer.

Updated Oct. 31, 2013, 3:58 p.m.

Repository: openlmi-providers

Description

Hardware: Added Physical Disk Provider

New Provider:
 * LMI_DiskPhysicalPackage

Diffs

mof/60_LMI_Hardware.mof (74e1ee5afc422506ca6769d025bfa4a4dedbd9f3)
openlmi-providers.spec (7b3a95ecaf320c86f0af2f7544e006da3c01e855)
src/hardware/CMakeLists.txt (8ccf649765ca98e8ca100d9ace454a0dc96f9721)
src/hardware/LMI_DiskPhysicalPackageProvider.c (PRE-CREATION)
src/hardware/LMI_Hardware.h (0ea623768b418b33cec91ec485664b9f3993c0e9)
src/hardware/dmidecode.h (d139f38d56a13a5e17aab79c303e725cf235f610)
src/hardware/smartctl.h (PRE-CREATION)
src/hardware/smartctl.c (PRE-CREATION)
src/hardware/sysfs.h (6ff7085d11def60f18b0c814addba79d038b2f52)
src/hardware/sysfs.c (4410ff716a566c217fc674b69a6d8a71b4900182)

View Diff