This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1986/

On September 1st, 2014, 10:43 a.m. CEST, Michal Minar wrote:

mof/60_LMI_SELinux.mof (Diff revision 1)
191
  Description("Association class the connects the SELinux system service with its elements."),

's/Association class the connects/Associates/'

On September 5th, 2014, 2:59 p.m. CEST, Jan Synacek wrote:

I don't really understand this change. It seems like a matter of opinion to me.

On September 8th, 2014, 8:25 a.m. CEST, Michal Minar wrote:

The thing is that the should prepend a noun not a verb. Perhaps you meant Association class that connects ...

Ok, I should read better next time. Thanks!


- Jan


On September 5th, 2014, 3:01 p.m. CEST, Jan Synacek wrote:

Review request for OpenLMI Developers.
By Jan Synacek.

Updated Sept. 5, 2014, 3:01 p.m.

Repository: openlmi-providers

Description

implement SELinux provider

In case diffs don't work, I'll track changes in my WIP branch until the patch is merged:

https://git.fedorahosted.org/cgit/openlmi-providers.git/log/?h=selinux-devel

Diffs

  • CMakeLists.txt (463da8c63a314dd34595710a127a0429f89edc49)
  • mof/60_LMI_SELinux.mof (PRE-CREATION)
  • mof/60_LMI_SELinux_MethodParameters.mof (PRE-CREATION)
  • mof/CMakeLists.txt (5e7aaa7f08d7f57277a0215970ba49064d6e0e69)
  • src/.dir-locals.el (PRE-CREATION)
  • src/CMakeLists.txt (58d72f596a1675e16ff06f437333859b54c00800)
  • src/libs/libopenlmi/openlmi.h (8f4770cde0d826fa95dabaa5a700934030f7bc90)
  • src/libs/libopenlmi/openlmi.c (da660a5bdb5c9fc37aa17031700bf3d93596d43a)
  • src/logicalfile/CMakeLists.txt (0448f1e8c04dba47b767edd4b84f049fe5e0cf26)
  • src/logicalfile/file.h (4caf84dd4db8dafc705fdd99738ff0e886db6323)
  • src/selinux/90_LMI_SELinux_Profile.mof.skel (PRE-CREATION)
  • src/selinux/CMakeLists.txt (PRE-CREATION)
  • src/selinux/LMI_AffectedSELinuxJobElementProvider.c (PRE-CREATION)
  • src/selinux/LMI_AssociatedSELinuxJobMethodResultProvider.c (PRE-CREATION)
  • src/selinux/LMI_HostedSELinuxServiceProvider.c (PRE-CREATION)
  • src/selinux/LMI_SELinuxBooleanProvider.c (PRE-CREATION)
  • src/selinux/LMI_SELinuxInstModificationProvider.c (PRE-CREATION)
  • src/selinux/LMI_SELinuxJobProvider.c (PRE-CREATION)
  • src/selinux/LMI_SELinuxMethodResultProvider.c (PRE-CREATION)
  • src/selinux/LMI_SELinuxPortProvider.c (PRE-CREATION)
  • src/selinux/LMI_SELinuxServiceHasElementProvider.c (PRE-CREATION)
  • src/selinux/LMI_SELinuxServiceProvider.c (PRE-CREATION)
  • src/selinux/cmpiLMI_SELinux-cimprovagt (PRE-CREATION)
  • src/selinux/selinux.h (PRE-CREATION)
  • src/selinux/selinux.c (PRE-CREATION)
  • src/selinux/test/README (PRE-CREATION)
  • src/selinux/test/__init__.py (PRE-CREATION)
  • src/selinux/test/test_selinux.py (PRE-CREATION)

View Diff