On September 1st, 2014, 10:43 a.m. CEST, Michal Minar wrote:

mof/60_LMI_SELinux.mof (Diff revision 1)
		172	[ IN, OUT, Description("SELinux file(s) to change. On output, all files that have unexpected SELinux context") ]

I don't see a way how a single reference to a unix file could refer to multiple files. If it's really possible, it should be mentioned in doc string.

This is an old and forgotten description. Will be fixed.

On September 1st, 2014, 10:43 a.m. CEST, Michal Minar wrote:

mof/60_LMI_SELinux.mof (Diff revision 1)
		191	Description("Association class the connects the SELinux system service with its elements."),

's/Association class the connects/Associates/'

I don't really understand this change. It seems like a matter of opinion to me.

On September 1st, 2014, 10:43 a.m. CEST, Michal Minar wrote:

mof/60_LMI_SELinux.mof (Diff revision 1)
		204	class LMI_HostedSELinuxService : CIM_HostedService

I would override at least Dependent and make it refer to LMI_SELinuxService.

Good idea.

On September 1st, 2014, 10:43 a.m. CEST, Michal Minar wrote:

src/libs/jobmanager/lmi_job.c (Diff revision 1)
void lmi_job_set_data(LmiJob *job,
1679	gboolean lmi_job_set_state(LmiJob *job,	1679	gboolean lmi_job_set_state(LmiJob *job,

Please, make this function static. Thanks :)

Done.

On September 1st, 2014, 10:43 a.m. CEST, Michal Minar wrote:

src/libs/jobmanager/lmi_job.c (Diff revision 1)
gboolean lmi_job_finish_ok_with_code(LmiJob *job, guint32 exit_code)
		1863	gchar verror[BUFSIZ + 1];
		1864	va_list args;
		1865
		1866	va_start(args, error);
		1867	vsnprintf(verror, BUFSIZ, error, args);
		1868	va_end(args);
		1869

Good catch!

I'll probably move this into a separate patch.

On September 1st, 2014, 10:43 a.m. CEST, Michal Minar wrote:

src/libs/libopenlmi/openlmi.c (Diff revision 1)
		787	gchar *lmi_strip_str(gchar *str, gchar c)

strip suggests removing of something from the beginning or the end. Perhaps lmi_ditch_char could be more appropriate.

This function should actually do the strip. I rewrote it.

- Jan

On August 29th, 2014, 12:56 p.m. CEST, Jan Synacek wrote:

implement SELinux provider
In case diffs don't work, I'll track changes in my WIP branch until the patch is merged:
https://git.fedorahosted.org/cgit/openlmi-providers.git/log/?h=selinux-devel