| This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/854/ |
| src/account/test/testAccount.py (Diff revision 6) | |||
|---|---|---|---|
| 99 | # clean up in a loop : it needs to be here for bug reproducing: |
||
| 100 | # delete user |
||
| 101 | user = self.conn.root.cimv2.LMI_Account.first_instance({"Name":myuser}) |
||
| 102 | user.delete() |
||
| 103 | self.assertFalse(user_exists(myuser)) |
||
| 104 | |||
| 105 | # delete group |
||
| 106 | group = self.conn.root.cimv2.LMI_Group.first_instance({"Name":myuser}) |
||
| 107 | group.delete() |
||
| 108 | self.assertFalse(group_exists(myuser)) |
||
This is cleanup? If yes, don't use lmi related code. We need clean system after test.
| src/account/test/testAccount.py (Diff revision 6) | |||
|---|---|---|---|
| 135 | # create 32char user |
||
| 136 | myuser = "32charabcdefghijklmnopqrstuvwxyz" |
||
| 137 | user = self.lams.CreateAccount(Name=myuser, System=self.cs) |
||
| 138 | self.assertEqual(user.rval, -1) |
||
| 139 | self.assertTrue('name is too long' in user.errorstr) |
||
I know that is only theoretical, but what will happen, when creating doesn't fail? Cleanup?
| src/account/test/testAccount.py (Diff revision 6) | |||
|---|---|---|---|
| 141 | # try to create superman, bug 1006260 |
||
| 142 | myuser = "superman" * 9999999 |
||
| 143 | user = self.lams.CreateAccount(Name=myuser, System=self.cs) |
||
| 144 | self.assertEqual(user.rval, -1) |
||
| 145 | self.assertTrue('name is too long' in user.errorstr) |
||
I know that is only theoretical, but what will happen, when creating doesn't fail? Cleanup?
- Robin Hack
On September 13th, 2013, 10:49 a.m. UTC, Robin Hack wrote:
|
Review request for OpenLMI Developers.
By Robin Hack.
Updated Sept. 13, 2013, 10:49 a.m.
Repository:
openlmi-providers
Description
Diffs
|