This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/430/

On May 19th, 2014, 2:06 p.m. UTC, Jan Safranek wrote:

The MOF file is now much better, thanks. On the other hand, I think you forgot to update the .c files appropriately :).
That's intentional - I want to be sure the model is 'correct' and 'final' before I start modifying .c files... Stay tuned:)

On May 19th, 2014, 2:06 p.m. UTC, Jan Safranek wrote:

mof/60_LMI_Locale.mof (Diff revisions 1 - 2)
55
    string X11Options;
161
    string X11Options;
The name suggests there can be more than one option. How are they separated?
Good point. They're comma separated. I'll update the description accordingly. Actually, it's also possible to set more than one layout in the same way, so it makes sense also renaming 'string X11Layout;' to 'string X11Layouts;' and document that fact too.

- Vitezslav


On May 19th, 2014, 11:23 a.m. UTC, Vitezslav Crhonek wrote:

Review request for OpenLMI Developers.
By Vitezslav Crhonek.

Updated May 19, 2014, 11:23 a.m.

Repository: openlmi-providers

Description

Locale: MOF

Diffs

  • mof/60_LMI_Locale.mof (PRE-CREATION)

View Diff