This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/430/ 

The MOF file is now much better, thanks. On the other hand, I think you forgot to update the .c files appropriately :).

mof/60_LMI_Locale.mof (Diff revisions 1 - 2)
55 
    string X11Options;
 161 
    string X11Options;
 
The name suggests there can be more than one option. How are they separated?

src/locale/LMI_LocaleProvider.c (Diff revision 1) 

    59
    
    cloc = locale_get_properties();

  


 





missing error check














 
  

   
    src/locale/LMI_LocaleProvider.c
    

     (Diff revision 1)

    
   
  

 



 
 

 

  

    
    

    64
    
    LMI_Locale_Init_Locale(&w, cloc->LocaleCnt);

  


  

    
    

    65
    
    for (int i = 0; i < cloc->LocaleCnt; i++)

  


  

    
    

    66
    
        LMI_Locale_Set_Locale(&w, i, cloc->Locale[i]);

  


 





This looks like it's for the older MOF file, we now have individual properties for these.














 
  

   
    src/locale/LMI_LocaleProvider.c
    

     (Diff revision 1)

    
   
  

 



 
 

 

  

    
    

    194
    
    for (int i = 0; i < LocaleCnt; i++)

  


  

    
    

    195
    
        LocaleValue[i] = KStringA_Get(Locale, i);

  


 





I think the API is different in the new MOF file.









- Jan Safranek






On May 19th, 2014, 1:23 p.m. CEST, Vitezslav Crhonek wrote:











 

  


Review request for OpenLMI Developers.


By Vitezslav Crhonek.




Updated May 19, 2014, 1:23 p.m.












 Repository: 
openlmi-providers





Description 

 

 

  
   
Locale: MOF



  		
 







Diffs 


    

 
  • mof/60_LMI_Locale.mof (PRE-CREATION)
    • 





View Diff