This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/690/ |
On August 23rd, 2013, 10:32 a.m. UTC, Michal Minar wrote:
mof/60_LMI_Journald.mof (Diff revision 2) 21 [ Version("0.0.1"), Provider("cmpi:cmpiLMI_Journald") ]Too old? I guess at least 0.1.0 should be here.
Changed to 0.2.0 for consistency with proposed change in software provider (review #742)
On August 23rd, 2013, 10:32 a.m. UTC, Michal Minar wrote:
mof/60_LMI_Journald.mof (Diff revision 2) 59 [ Override("MessageLog"), Key, Aggregate, Min (1), Max (1) ]Having Override("Property") in property's qualifiers renders all the other qualifiers unnecessary if they don't override anything. Aggregate, Key, Min and Max can be omitted here. The same applies to other overriden properties.
Thanks, didn't know that, still learning. Did a cleanup, removed duplicite qualifiers comapring to super class' MOF. Seems to be working fine.
- Tomáš
On August 23rd, 2013, 12:55 p.m. UTC, Tomáš Bžatek wrote:
Review request for OpenLMI Developers.
By Tomáš Bžatek.
Updated Aug. 23, 2013, 12:55 p.m.
Repository:
openlmi-providers
Description
Diffs
|