This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/426/ |
src/account/LMI_AccountProvider.c (Diff revision 1) | |||
---|---|---|---|
static CMPIStatus LMI_AccountModifyInstance( |
|||
275 | CMReturnWithChars(_cb, CMPI_RC_ERR_NOT_FOUND, errmsg); |
274 | CMReturnWithChars(_cb, CMPI_RC_ERR_NOT_FOUND, errmsg); |
errmsg must be freed here (this also apply for other uses below).
There are quite a lot of memory leaks when using CMReturnWithChars macro. I would suggest to define new macro based on implementation of CMReturnWithChars that will also free the "errmsg" string.
- Radek
On May 31st, 2013, 5:12 p.m. CEST, Roman Rakus wrote:
Review request for OpenLMI Developers.
By Roman Rakus.
Updated May 31, 2013, 5:12 p.m.
Repository:
openlmi-providers
Description
Diffs
|