This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/426/

src/account/LMI_AccountProvider.c (Diff revision 1)
static CMPIStatus LMI_AccountModifyInstance(
275
        CMReturnWithChars(_cb, CMPI_RC_ERR_NOT_FOUND, errmsg);
274
        CMReturnWithChars(_cb, CMPI_RC_ERR_NOT_FOUND, errmsg);
errmsg must be freed here (this also apply for other uses below).

There are quite a lot of memory leaks when using CMReturnWithChars macro. I would suggest to define new macro based on implementation of CMReturnWithChars that will also free the "errmsg" string.

- Radek


On May 31st, 2013, 5:12 p.m. CEST, Roman Rakus wrote:

Review request for OpenLMI Developers.
By Roman Rakus.

Updated May 31, 2013, 5:12 p.m.

Repository: openlmi-providers

Description

Account: Use asprintf instead of snprintf

Signed-off-by: Roman Rakus <rrakus@redhat.com>

Diffs

  • src/account/LMI_AccountManagementServiceProvider.c (1af6cf4f55f574d3bf665202ff7b55224a8d9009)
  • src/account/LMI_AccountProvider.c (27be7e15f706b681cf07f83cec56fef2ccc7ecf5)
  • src/account/LMI_AssignedAccountIdentityProvider.c (323a582217cd1c101863cc489b3e4ee94aa3a4ff)
  • src/account/LMI_AssignedGroupIdentityProvider.c (a9037f1bd86a39ef21869796a692a0ec85affb08)
  • src/account/LMI_GroupProvider.c (a9c547724ecf8e66f92efb1677ee3b6f348f6051)
  • src/account/LMI_IdentityProvider.c (92c2b0119a3dd81ca62be99c6e09f894f46841cd)
  • src/account/LMI_MemberOfGroupProvider.c (dddd2e80952d7a1bedc0a0291ada56b5d7a1aea9)
  • src/account/LMI_ServiceAffectsIdentityProvider.c (64e218b4068c696dbb5479d7e73c2f38b4fc0cb5)

View Diff