This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/795/

src/account/LMI_AccountProvider.c (Diff revision 2)
static void LMI_AccountInitialize()		static const CMPIBroker* _cb = NULL;
56	static void LMI_AccountInitialize()	57	static void LMI_AccountInitialize()
57	{	58	{
		59	if (init_lock_pool() == 0) {
		60	CMReturn(CMPI_RC_ERR_FAILED);
		61	}
58	}	62	}

Does this work? The function returns void, but CMReturn is returning CMPIStatus. I'm not sure if it is possible to do any checks here.

src/account/lock.c (Diff revision 2)
		161	assert (pool != NULL);

Is it good to abort here? It should return some error indication rather.

- Roman Rakus

On September 9th, 2013, 9:53 a.m. UTC, Robin Hack wrote:

Review request for OpenLMI Developers.

By Robin Hack.

Updated Sept. 9, 2013, 9:53 a.m.

Repository: openlmi-providers

Description

Account: Added associative thread locking.

Diffs