This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/687/

On August 7th, 2013, 6:24 a.m. UTC, Michal Minar wrote:
Ship It!
On August 7th, 2013, 11:58 a.m. UTC, Stephen Gallagher wrote:
Actually, testing revealed that this fix was incomplete. Do not ship right now please.
On August 8th, 2013, 5:18 a.m. UTC, Peter Hatina wrote:
What do you mean, the fix was incomplete? Are you talking about a pywbem pending patch? I would like to include this one into v0.7 release.

Sorry for the delay, I've been out of the office at Flock. What I meant was that when I tested it, we discovered it wasn't working. Ultimately, it was discovered that the issue was in pywbem, not lmishell. So this patch should be fine as long as it lands together with the pywbem fix.

- Stephen

On August 6th, 2013, 8:22 p.m. UTC, Peter Hatina wrote:

Review request for OpenLMI Developers.

By Peter Hatina.

Updated Aug. 6, 2013, 8:22 p.m.

Repository: openlmi-tools

Description

This patch introduces server side certificate check, if SSL used. LMIShell can be told not to verify the certificate by CLI option -n, --noverify.

Diffs

cli/lmi/shell/LMIBaseClient.py (a8ecbcb116de488c6099e6da71631323e98610b7)
cli/lmi/shell/LMIConnection.py (c1ecaea86a7a02479eaae37cfc1720203bf97202)
cli/lmi/shell/LMIConsole.py (f81099fa84f1dadf3ac59597f3f020a521320899)
cli/lmi/shell/LMIShellClient.py (ca9a927464de4e67a5331cb095be34ab0b01e903)
cli/lmi/shell/LMIShellOptions.py (3e182a7e8ebcbebd78d526b2c938f20455dd1a29)
cli/lmishell (a49a2fa29342ecefbf48626e1caa285df1cfa16b)

View Diff