package-review February 2007

package-review@lists.fedoraproject.org

1 participants
2523 discussions

fedora-review denied: [Bug 225774] Merge Review: ftp
by Red Hat Bugzilla 06 Feb '07

06 Feb '07

Bug 225774: Merge Review: ftp Product: Fedora Extras Version: devel Component: Package Review Ruben Kerkhof <ruben(a)rubenkerkhof.com> has denied Roozbeh Pournader <roozbeh(a)farsiweb.info>'s request for fedora-review: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225774 ------- Additional Comments from Ruben Kerkhof <ruben(a)rubenkerkhof.com> This looks much better! A few details: * Remove the commented out BuildRoot, rpmlint complains about it * Preserve timestamps when installing files (use install -p or cp -p)

1 0

fedora-review granted: [Bug 226514] Merge Review: unix2dos
by Red Hat Bugzilla 06 Feb '07

06 Feb '07

Bug 226514: Merge Review: unix2dos Product: Fedora Extras Version: devel Component: Package Review Ruben Kerkhof <ruben(a)rubenkerkhof.com> has granted Tim Waugh <twaugh(a)redhat.com>'s request for fedora-review: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226514 ------- Additional Comments from Ruben Kerkhof <ruben(a)rubenkerkhof.com> Ah, Distributable (with a capital D) is a valid license. distributable is not. DEFAULT_VALID_LICENSES in /usr/share/rpmlint/TagsCheck.py contains a list of valid licenses. If you can change that, it would be nice. Since I see no further blockers, this package is approved. Please leave the ticket assigned to yourself.

1 0

fedora-review granted: [Bug 226260] Merge Review: perl-HTML-Parser
by Red Hat Bugzilla 06 Feb '07

06 Feb '07

Bug 226260: Merge Review: perl-HTML-Parser Product: Fedora Extras Version: devel Component: Package Review Jose Pedro Oliveira <jpo(a)di.uminho.pt> has granted Jose Pedro Oliveira <jpo(a)di.uminho.pt>'s request for fedora-review: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226260 ------- Additional Comments from Jose Pedro Oliveira <jpo(a)di.uminho.pt> Robin, Looks good. jpo

1 0

fedora-review granted: [Bug 226247] Merge Review: perl-Convert-ASN1
by Red Hat Bugzilla 06 Feb '07

06 Feb '07

Bug 226247: Merge Review: perl-Convert-ASN1 Product: Fedora Extras Version: devel Component: Package Review Jose Pedro Oliveira <jpo(a)di.uminho.pt> has granted Jose Pedro Oliveira <jpo(a)di.uminho.pt>'s request for fedora-review: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226247 ------- Additional Comments from Jose Pedro Oliveira <jpo(a)di.uminho.pt> Robin, Looks good. jpo

1 0

fedora-review requested: [Bug 226411] Merge Review: setserial
by Red Hat Bugzilla 06 Feb '07

06 Feb '07

Bug 226411: Merge Review: setserial Product: Fedora Extras Version: devel Component: Package Review Tim Waugh <twaugh(a)redhat.com> has asked for fedora-review: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226411

1 0

fedora-review requested: [Bug 226415] Merge Review: sgml-common
by Red Hat Bugzilla 06 Feb '07

06 Feb '07

Bug 226415: Merge Review: sgml-common Product: Fedora Extras Version: devel Component: Package Review Tim Waugh <twaugh(a)redhat.com> has asked for fedora-review: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226415

1 0

fedora-review requested: [Bug 226436] Merge Review: statserial
by Red Hat Bugzilla 06 Feb '07

06 Feb '07

Bug 226436: Merge Review: statserial Product: Fedora Extras Version: devel Component: Package Review Tim Waugh <twaugh(a)redhat.com> has asked for fedora-review: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226436

1 0

fedora-review requested: [Bug 226445] Merge Review: symlinks
by Red Hat Bugzilla 06 Feb '07

06 Feb '07

Bug 226445: Merge Review: symlinks Product: Fedora Extras Version: devel Component: Package Review Tim Waugh <twaugh(a)redhat.com> has asked for fedora-review: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226445

1 0

fedora-review requested: [Bug 226466] Merge Review: system-config-printer
by Red Hat Bugzilla 06 Feb '07

06 Feb '07

Bug 226466: Merge Review: system-config-printer Product: Fedora Extras Version: devel Component: Package Review Tim Waugh <twaugh(a)redhat.com> has asked for fedora-review: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226466

1 0

fedora-review denied: [Bug 225797] Merge Review: gimp-data-extras
by Red Hat Bugzilla 06 Feb '07

06 Feb '07

Bug 225797: Merge Review: gimp-data-extras Product: Fedora Extras Version: devel Component: Package Review Roozbeh Pournader <roozbeh(a)farsiweb.info> has denied Roozbeh Pournader <roozbeh(a)farsiweb.info>'s request for fedora-review: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225797 ------- Additional Comments from Roozbeh Pournader <roozbeh(a)farsiweb.info> Random first notes: * Release (1.1.1) should be an integer. You may also add %{?dist} if you wish. * separate the BuildRequires into two lines. It's not very obvious now. * change BuildRoot to %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) * remove the dot at the end of Summary. * As /usr/bin is in the execution path, saying /usr/bin/gimptool in the install section is not necessary. Just use "gimptool", which makes the spec more legible. * Use %defattr (-, root, root, -) instead of %defattr (-, root, root) * The license filed says GPL, while there is nothing in the source tarball that confirms that. The COPYING file is also empty. (BLOCKER) * You should ship some of the files as %doc (at least AUTHORS, ChangeLog, NEWS, and README). * The spec file is not UTF-8. (BLOCKER) * The install root is not cleaned at the beginning of %install

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

package-review February 2007