Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=553769
--- Comment #4 from Garrett Holmstrom gholms.fedora@gmail.com 2010-01-20 20:32:01 EST --- (In reply to comment #3)
Thanks for the review!
Nothing owns "%{python_sitelib}/euca2ools". [...]
Fixed.
Note that the BuildRoot tag is not required for Fedora, nor is the "rm -rf" line at the start of %install. I would suggest that you remove these unless you plan to submit this package to EPEL and want to keep the same spec for all releases. (I'm guessing you don't, since you require python 2.5.)
Consider not using versioned dependencies unless there exists a supported Fedora release that at some point had a version which is too old. [...]
Fixed, though rpmlint doesn't like the lack of buildroot-related bits. I initially planned to build this for el5 at $dayjob, where we also install Python 2.6, but that idea since went out the window and those bits lingered.
Why does this have any dependency on swig? I can't see where the code would call swig at runtime, and I don't see why it's required at build time. INSTALL says only that swig is needed to build the dependencies, but you're not building them.
Also fixed.
Spec: http://www.physics.umn.edu/~holms/euca2ools-1.1-4.fc12.spec SRPM: http://www.physics.umn.edu/~holms/euca2ools-1.1-4.fc12.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1935159